From 9f7d19f2fb38fc5f2b082ed2e9bfc7dd6193b85d Mon Sep 17 00:00:00 2001
From: Simon Rettberg
Date: Wed, 21 Apr 2021 15:33:25 +0200
Subject: [Transfer] Better error messages and handling for downloads

---
 .../openslx/filetransfer/util/IncomingTransferBase.java    | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

(limited to 'src/main/java/org/openslx/filetransfer/util/IncomingTransferBase.java')

diff --git a/src/main/java/org/openslx/filetransfer/util/IncomingTransferBase.java b/src/main/java/org/openslx/filetransfer/util/IncomingTransferBase.java
index 8a69020..300a75f 100644
--- a/src/main/java/org/openslx/filetransfer/util/IncomingTransferBase.java
+++ b/src/main/java/org/openslx/filetransfer/util/IncomingTransferBase.java
@@ -389,7 +389,7 @@ public abstract class IncomingTransferBase extends AbstractTransfer implements H
 				currentChunk = chunks.getMissing();
 			} catch ( InterruptedException e ) {
 				Thread.currentThread().interrupt();
-				cancel();
+				LOGGER.info("Incoming transfer connection was interrupted");
 				return null;
 			}
 			if ( currentChunk == null ) {
@@ -600,7 +600,7 @@ public abstract class IncomingTransferBase extends AbstractTransfer implements H
 		}
 		// A block finished, see if we can queue a new one
 		queueUnhashedChunk( false );
-		if ( localCopyManager != null ) {
+		if ( localCopyManager != null && localCopyManager.isAlive() ) {
 			localCopyManager.trigger();
 		}
 	}
@@ -645,7 +645,7 @@ public abstract class IncomingTransferBase extends AbstractTransfer implements H
 
 	final synchronized void finishUploadInternal()
 	{
-		if ( state == TransferState.FINISHED ) {
+		if ( state == TransferState.FINISHED || state == TransferState.ERROR ) {
 			return;
 		}
 		try {
@@ -659,13 +659,9 @@ public abstract class IncomingTransferBase extends AbstractTransfer implements H
 		if ( localCopyManager != null ) {
 			localCopyManager.interrupt();
 		}
-		if ( state != TransferState.WORKING ) {
+		state = TransferState.FINISHED; // Races...
+		if ( !finishIncomingTransfer() ) {
 			state = TransferState.ERROR;
-		} else {
-			state = TransferState.FINISHED; // Races...
-			if ( !finishIncomingTransfer() ) {
-				state = TransferState.ERROR;
-			}
 		}
 	}
 	
-- 
cgit v1.2.3-55-g7522