bwlp/qemu.git/CODING_STYLE, branch spice_video_codecs

docs: convert README, CODING_STYLE and HACKING to RST syntax

2019-09-05T13:27:06+00:00

Reviewed-by: Alex Bennée Signed-off-by: Daniel P. Berrangé

CODING_STYLE: indent example code as all others

2019-05-02T16:12:58+00:00

All the example code are indented with four spaces except this one. Fix this by adding four spaces here. Signed-off-by: Wei Yang Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov Reviewed-by: Stefano Garzarella Message-Id: <20190304071631.27567-3-richardw.yang@linux.intel.com> Signed-off-by: Laurent Vivier

CODING_STYLE: specify the indent rule for multiline code

2019-05-02T16:12:58+00:00

We didn't specify the indent rule for multiline code here, which may mislead users. And in current code, the code use various styles. Add this rule in CODING_STYLE to make sure this is clear to every one. Signed-off-by: Wei Yang Suggested-by: Igor Mammedov Reviewed-by: Igor Mammedov Reviewed-by: Stefano Garzarella Message-Id: <20190304071631.27567-2-richardw.yang@linux.intel.com> Signed-off-by: Laurent Vivier

CODING_STYLE: Define our preferred form for multiline comments

2018-06-15T14:23:34+00:00

The codebase has a bit of a mix of different multiline comment styles. State a preference for the Linux kernel style: /* * Star on the left for each line. * Leading slash-star and trailing star-slash * each go on a line of their own. */ Signed-off-by: Peter Maydell Reviewed-by: Eric Blake Reviewed-by: Cornelia Huck Reviewed-by: Markus Armbruster Reviewed-by: Alex Williamson Reviewed-by: Thomas Huth Reviewed-by: John Snow Reviewed-by: Stefan Hajnoczi Message-id: 20180611141716.3813-1-peter.maydell@linaro.org

coding_style: add point about 0x in trace-events

2017-08-01T11:13:07+00:00

Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Message-id: 20170731160135.12101-2-vsementsov@virtuozzo.com Signed-off-by: Stefan Hajnoczi

CODING_STYLE: Mention preferred comment form

2017-02-28T06:03:38+00:00

Our defacto coding style strongly prefers /* */ style comments over the single-line // style, and checkpatch enforces this, but we don't actually document this. Mention it in CODING_STYLE. Suggested-by: Thomas Huth Signed-off-by: Peter Maydell Reviewed-by: Markus Armbruster Reviewed-by: Fam Zheng Reviewed-by: Laurent Vivier Reviewed-by: Stefan Hajnoczi Signed-off-by: Michael Tokarev

CODING_STYLE: Fix a typo ("have" vs. "has")

2016-10-08T08:25:29+00:00

Signed-off-by: Jonathan Neuschäfer Reviewed-by: Peter Maydell Signed-off-by: Michael Tokarev

CODING_STYLE, checkpatch: update line length rules

2016-08-10T10:22:33+00:00

Line lengths above 80 characters do exist. They are rare, but they happen from time to time. An ignored rule is worse than an exception to the rule, so do the latter. Some on the list expressed their preference for a soft limit that is slightly lower than 80 characters, to account for extra characters in unified diffs (including three-way diffs) and for email quoting. However, there was no consensus on this so keep the 80-character soft limit and add a hard limit at 90. Acked-by: Cornelia Huck Reviewed-by: Thomas Huth Signed-off-by: Paolo Bonzini

CODING_STYLE: update mixed declaration rules

2015-09-09T13:34:54+00:00

Mixed declarations do come in handy at the top of #ifdef blocks. Reluctantly allow this particular usage and suggest an alternative. Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini

CODING_STYLE: Section about conditional statement

2014-08-15T14:54:06+00:00

Yoda conditions lack readability, and QEMU has a strict compiler configuration for checking a common mistake like "if (dev = NULL)". Make it a written rule. Signed-off-by: Gonglei Reviewed-by: Eric Blake Signed-off-by: Michael Tokarev