bwlp/qemu.git/HACKING, branch spice_video_codecs

docs: convert README, CODING_STYLE and HACKING to RST syntax

2019-09-05T13:27:06+00:00

Reviewed-by: Alex Bennée Signed-off-by: Daniel P. Berrangé

HACKING: Document 'struct' keyword usage

2019-08-20T18:00:51+00:00

Sometimes we use the 'struct' keyword in headers to help us reduce dependencies between header files. Document that practice. Signed-off-by: Paolo Bonzini Signed-off-by: Eduardo Habkost Signed-off-by: Paolo Bonzini

HACKING: document preference for g_new instead of g_malloc

2018-05-20T05:32:09+00:00

This patch documents the preference for g_new instead of g_malloc. The reasons were adapted from commit b45c03f585ea9bb1af76c73e82195418c294919d. Discussion in QEMU's mailing list: http://lists.nongnu.org/archive/html/qemu-devel/2018-05/msg03238.html Cc: qemu-devel@nongnu.org Cc: David Hildenbrand Cc: Eduardo Habkost Cc: Markus Armbruster Cc: Paolo Bonzini Signed-off-by: Murilo Opsfelder Araujo Reviewed-by: Eric Blake Reviewed-by: Alex Bennée Reviewed-by: David Hildenbrand Signed-off-by: Michael Tokarev

HACKING: document #include order

2017-01-03T16:38:47+00:00

It was not obvious to me why "qemu/osdep.h" must be the first #include. This documents the rationale and the overall #include order. Cc: Fam Zheng Cc: Markus Armbruster Cc: Eric Blake Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster Message-id: 1479307161-24658-1-git-send-email-stefanha@redhat.com Signed-off-by: Stefan Hajnoczi

Disable warn about left shifts of negative values

2016-08-09T20:57:36+00:00

It seems like there's no good reason for the compiler to exploit the undefinedness of left shifts. GCC explicitly documents that they do not use at all this possibility and, while they also say this is subject to change, they have been saying this for 10 years (since the wording appeared in the GCC 4.0 manual). Disable these warnings by passing in -Wno-shift-negative-value. Cc: Peter Maydell Cc: Markus Armbruster Cc: Laszlo Ersek Signed-off-by: Paolo Bonzini [pranith: forward-port part of patch to 2.7] Signed-off-by: Pranith Kumar

HACKING: Add a section on error handling and reporting

2016-02-09T12:19:49+00:00

Inspired by an RFC PATCH from Lluís Vilanova. Signed-off-by: Markus Armbruster Message-Id: <1454522628-28294-3-git-send-email-armbru@redhat.com> Reviewed-by: Lluís Vilanova

HACKING: Document vaddr type usage

2013-07-23T00:41:31+00:00

Also extend documentation of target_ulong and abi_ulong. Signed-off-by: Peter Maydell Signed-off-by: Andreas Färber

osdep, kvm: rename low-level RAM allocation functions

2013-05-14T13:53:31+00:00

This is preparatory to the introduction of a separate freeing API. Reported-by: Amos Kong Signed-off-by: Paolo Bonzini Reviewed-by: Amos Kong Message-id: 1368454796-14989-2-git-send-email-pbonzini@redhat.com Signed-off-by: Anthony Liguori

HACKING: List areas where we may rely on impdef C behaviour

2012-12-08T14:27:40+00:00

Add a section to HACKING saying which version of the C spec we use and describing the bits of implementation defined C compiler behaviour which C code in QEMU is allowed to rely on. Signed-off-by: Peter Maydell Signed-off-by: Blue Swirl

Rename target_phys_addr_t to hwaddr

2012-10-23T13:58:25+00:00

target_phys_addr_t is unwieldly, violates the C standard (_t suffixes are reserved) and its purpose doesn't match the name (most target_phys_addr_t addresses are not target specific). Replace it with a finger-friendly, standards conformant hwaddr. Outstanding patchsets can be fixed up with the command git rebase -i --exec 'find -name "*.[ch]" | xargs s/target_phys_addr_t/hwaddr/g' origin Signed-off-by: Avi Kivity Signed-off-by: Anthony Liguori