bwlp/qemu.git/scripts/qmp/qemu-ga-client, branch master

python: move qmp utilities to python/qemu/utils

2022-01-21T21:01:31+00:00

In order to upload a QMP package to PyPI, I want to remove any scripts that I am not 100% confident I want to support upstream, beyond our castle walls. Move most of our QMP utilities into the utils package so we can split them out from the PyPI upload. Signed-off-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Beraldo Leal

scripts/qemu-ga-client: Add forwarder shim

2021-06-18T20:10:06+00:00

Add a little forwarder shim until we are sure that everyone is comfortable with how to use the tools in their new packaged location. Signed-off-by: John Snow Message-id: 20210604155532.1499282-12-jsnow@redhat.com Signed-off-by: John Snow

scripts/qemu-ga-client: move to python/qemu/qmp/qemu_ga_client.py

2021-06-18T20:10:06+00:00

The script itself will be unavailable for a few commits before being restored, with no way to run it right after this commit. This helps move git history into the new file. To prevent linter regressions, though, we do need to immediately touch up the filename to remove dashes (to make the module importable), and remove the executable bit. Signed-off-by: John Snow Message-id: 20210604155532.1499282-10-jsnow@redhat.com Signed-off-by: John Snow

scripts/qemu-ga-client: add mypy type hints

2021-06-18T20:10:06+00:00

This script is in slightly rough shape, but it still works. A lot of care went into its initial development. In good faith, I'm updating it to the latest Python coding standards. If there is in interest in this script, though, I'll be asking for a contributor to take care of it further. Signed-off-by: John Snow Message-id: 20210604155532.1499282-9-jsnow@redhat.com Signed-off-by: John Snow

scripts/qemu-ga-client: apply (most) pylint rules

2021-06-18T20:10:06+00:00

I'm only doing a very quick best-effort to preserve this script, to help keep it from breaking further. I think there are pending ideas swirling on the right way to implement better SDKs and better clients, and this script might be a handy reference for those discussions. It presents some interesting design problems, like static type safety when using a dynamic RPC mechanism. I believe it's worth preserving the effort and care that went into making this script by updating it to work with our current infrastructure. However, I am disabling the requirement for docstrings in this file. If you would like to help improve this script, please add docstrings alongside any refactors or rejuvenations you might apply at that time. Signed-off-by: John Snow Message-id: 20210604155532.1499282-7-jsnow@redhat.com Signed-off-by: John Snow

scripts/qemu-ga-client: add module docstring

2021-06-18T20:10:06+00:00

Turn that nice usage comment into a docstring. Signed-off-by: John Snow Message-id: 20210604155532.1499282-6-jsnow@redhat.com Signed-off-by: John Snow

scripts/qemu-ga-client: replace deprecated optparse with argparse

2021-06-18T20:10:06+00:00

optparse isn't supported anymore, it's from the python2 days. Replace it with the mostly similar argparse. Signed-off-by: John Snow Message-id: 20210604155532.1499282-5-jsnow@redhat.com Signed-off-by: John Snow

scripts/qemu-ga-client: Fix exception handling

2021-06-18T20:10:06+00:00

Fixes: 50d189c These error classes aren't available anymore. Fix the bitrot. Signed-off-by: John Snow Message-id: 20210604155532.1499282-4-jsnow@redhat.com Signed-off-by: John Snow

scripts/qemu-ga-client: apply (most) flake8 rules

2021-06-18T20:10:06+00:00

- Line length should be < 80 - You shouldn't perform unscoped imports except at the top of the module Notably, the sys.path hack creates problems with the import rule. This will be fixed later. Signed-off-by: John Snow Message-id: 20210604155532.1499282-3-jsnow@redhat.com Signed-off-by: John Snow

scripts/qemu-ga-client: apply isort rules

2021-06-18T20:10:06+00:00

Hint: > ln -s scripts/qmp/qemu-ga-client python/qemu/qmp/qemu_ga_client.py > cd python > isort qemu Signed-off-by: John Snow Message-id: 20210604155532.1499282-2-jsnow@redhat.com Signed-off-by: John Snow