bwlp/qemu.git/scripts/qmp/qom-fuse, branch master

python: move qmp utilities to python/qemu/utils

2022-01-21T21:01:31+00:00

In order to upload a QMP package to PyPI, I want to remove any scripts that I am not 100% confident I want to support upstream, beyond our castle walls. Move most of our QMP utilities into the utils package so we can split them out from the PyPI upload. Signed-off-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Beraldo Leal

scripts/qom-fuse: add redirection shim to python/qemu/qmp/qom-fuse.py

2021-06-18T20:10:06+00:00

By leaving the script absent for a commit, git-blame travels to the new file instead of staying on the shim. Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Message-id: 20210603003719.1321369-19-jsnow@redhat.com Signed-off-by: John Snow

scripts/qom-fuse: move to python/qemu/qmp/qom_fuse.py

2021-06-18T20:10:06+00:00

Move qom-fuse over to the python package now that it passes the linter. Update the import paradigms so that it continues to pass in the context of the Python package. Signed-off-by: John Snow Message-id: 20210603003719.1321369-18-jsnow@redhat.com Signed-off-by: John Snow

scripts/qom-fuse: add static type hints

2021-06-18T20:10:06+00:00

Because fusepy does not have type hints, add some targeted warning suppressions. Namely, we need to allow subclassing something of an unknown type (in qom_fuse.py), and we need to allow missing imports (recorded against fuse itself) because mypy will be unable to import fusepy (even when installed) as it has no types nor type stubs available. Note: Until now, it was possible to run invocations like 'mypy qemu/' from ./python and have that work. However, these targeted suppressions require that you run 'mypy -p qemu/' instead. The correct, canonical invocation is recorded in ./python/tests/mypy.sh and all of the various CI invocations always use this correct form. Signed-off-by: John Snow Message-id: 20210603003719.1321369-16-jsnow@redhat.com Signed-off-by: John Snow

scripts/qom-fuse: ensure QOMFuse.read always returns bytes

2021-06-18T20:10:06+00:00

- Use FuseOSError to signal ENOENT instead of returning it - Wrap qom-get in str(), as we don't always know its type - The empty return should be b'', not ''. Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Message-id: 20210603003719.1321369-15-jsnow@redhat.com Signed-off-by: John Snow

scripts/qom-fuse: use QOMCommand.qom_list()

2021-06-18T20:10:06+00:00

the qom_list method provides a type-safe object that's easier to type check, so switch to using it. Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Message-id: 20210603003719.1321369-14-jsnow@redhat.com Signed-off-by: John Snow

scripts/qom-fuse: Convert to QOMCommand

2021-06-18T20:10:06+00:00

Move qom-fuse onto the QOMCommand base established in python/qemu/qmp/qom_common.py. The interface doesn't change incompatibly, "qom-fuse mountpoint" still works as an invocation, and QMP_SOCKET is still used as the environment variable. Signed-off-by: John Snow Message-id: 20210603003719.1321369-13-jsnow@redhat.com Signed-off-by: John Snow

scripts/qom-fuse: Add docstrings

2021-06-18T20:10:06+00:00

The methods inherited from fuse don't need docstrings; that's up to fusepy to handle. Signed-off-by: John Snow Message-id: 20210603003719.1321369-12-jsnow@redhat.com Signed-off-by: John Snow

scripts/qom-fuse: Apply pylint rules

2021-06-18T20:10:06+00:00

- Catch specific exceptions from QMP - Reraise errors with explicit context - method parameters should match parent's names Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Message-id: 20210603003719.1321369-11-jsnow@redhat.com Signed-off-by: John Snow

scripts/qom-fuse: apply flake8 rules

2021-06-18T20:10:06+00:00

flake8 still has one warning because of the sys.path hack, but that will be going away by the end of this patch series. Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Message-id: 20210603003719.1321369-9-jsnow@redhat.com Signed-off-by: John Snow