bwlp/qemu.git/tests/image-fuzzer, branch spice_video_codecs

image-fuzzer: Use OSerror.strerror instead of tuple subscript

2019-11-05T15:36:11+00:00

OSError can't be used like a tuple on Python 3, so change the code to use `e.sterror` instead of `e[1]`. Reported-by: John Snow Signed-off-by: Eduardo Habkost Reviewed-by: John Snow Message-id: 20191021214117.18091-1-ehabkost@redhat.com Message-Id: <20191021214117.18091-1-ehabkost@redhat.com> Signed-off-by: Stefan Hajnoczi

image-fuzzer: Use errors parameter of subprocess.Popen()

2019-11-05T15:35:06+00:00

Instead of manually encoding stderr and stdout output, use `errors` parameter of subprocess.Popen(). This will make process.communicate() return unicode strings instead of bytes objects. Signed-off-by: Eduardo Habkost Reviewed-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Message-id: 20191016192430.25098-11-ehabkost@redhat.com Message-Id: <20191016192430.25098-11-ehabkost@redhat.com> Signed-off-by: Stefan Hajnoczi

image-fuzzer: Run using python3

2019-11-05T15:35:06+00:00

image-fuzzer is now supposed to be ready to run using Python 3. Remove the __future__ imports and change the interpreter line to "#!/usr/bin/env python3". Signed-off-by: Eduardo Habkost Reviewed-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Message-id: 20191016192430.25098-10-ehabkost@redhat.com Message-Id: <20191016192430.25098-10-ehabkost@redhat.com> Signed-off-by: Stefan Hajnoczi

image-fuzzer: Encode file name and file format to bytes

2019-11-05T15:35:06+00:00

Callers of create_image() will pass strings as arguments, but the Image class will expect bytes objects to be provided. Encode them inside create_image(). Signed-off-by: Eduardo Habkost Reviewed-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Message-id: 20191016192430.25098-9-ehabkost@redhat.com Message-Id: <20191016192430.25098-9-ehabkost@redhat.com> Signed-off-by: Stefan Hajnoczi

image-fuzzer: Use bytes constant for field values

2019-11-05T15:35:06+00:00

Field values are supposed to be bytes objects, not unicode strings. Change two constants that were declared as strings. Signed-off-by: Eduardo Habkost Reviewed-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Message-id: 20191016192430.25098-8-ehabkost@redhat.com Message-Id: <20191016192430.25098-8-ehabkost@redhat.com> Signed-off-by: Stefan Hajnoczi

image-fuzzer: Return bytes objects on string fuzzing functions

2019-11-05T15:35:06+00:00

No caller of fuzzer functions is interested in unicode string values, so replace them with bytes sequences. Signed-off-by: Eduardo Habkost Reviewed-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Message-id: 20191016192430.25098-7-ehabkost@redhat.com Message-Id: <20191016192430.25098-7-ehabkost@redhat.com> Signed-off-by: Stefan Hajnoczi

image-fuzzer: Use %r for all fiels at Field.repr()

2019-11-05T15:35:06+00:00

This makes the formatting code simpler, and safer if we change the type of self.value from str to bytes. Signed-off-by: Eduardo Habkost Reviewed-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Message-id: 20191016192430.25098-6-ehabkost@redhat.com Message-Id: <20191016192430.25098-6-ehabkost@redhat.com> Signed-off-by: Stefan Hajnoczi

image-fuzzer: Use io.StringIO

2019-11-05T15:35:06+00:00

StringIO.StringIO is not available on Python 3, but io.StringIO is available on both Python 2 and 3. io.StringIO is slightly different from the Python 2 StringIO module, though, so we need bytes coming from subprocess.Popen() to be explicitly decoded. Signed-off-by: Eduardo Habkost Reviewed-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Message-id: 20191016192430.25098-5-ehabkost@redhat.com Message-Id: <20191016192430.25098-5-ehabkost@redhat.com> Signed-off-by: Stefan Hajnoczi

image-fuzzer: Explicitly use integer division operator

2019-11-05T15:35:06+00:00

Most of the division expressions in image-fuzzer assume integer division. Use the // operator to keep the same behavior when we move to Python 3. Signed-off-by: Eduardo Habkost Reviewed-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Message-id: 20191016192430.25098-4-ehabkost@redhat.com Message-Id: <20191016192430.25098-4-ehabkost@redhat.com> Signed-off-by: Stefan Hajnoczi

image-fuzzer: Write bytes instead of string to image file

2019-11-05T15:35:06+00:00

This is necessary for Python 3 compatibility. Signed-off-by: Eduardo Habkost Reviewed-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Message-id: 20191016192430.25098-3-ehabkost@redhat.com Message-Id: <20191016192430.25098-3-ehabkost@redhat.com> Signed-off-by: Stefan Hajnoczi

bwlp/qemu.git/tests/image-fuzzer, branch spice_video_codecs

image-fuzzer: Use OSerror.strerror instead of tuple subscript

image-fuzzer: Use errors parameter of subprocess.Popen()

image-fuzzer: Run using python3

image-fuzzer: Encode file name and file format to bytes

image-fuzzer: Use bytes constant for field values

image-fuzzer: Return bytes objects on string fuzzing functions

image-fuzzer: Use %r for all fiels at Field.__repr__()

image-fuzzer: Use io.StringIO

image-fuzzer: Explicitly use integer division operator

image-fuzzer: Write bytes instead of string to image file

image-fuzzer: Use %r for all fiels at Field.repr()