diff options
| author | Michael S. Tsirkin | 2010-01-11 16:57:41 +0100 |
|---|---|---|
| committer | Anthony Liguori | 2010-01-11 20:41:00 +0100 |
| commit | 49e75cf38848e6da70c0e9ddb4d994e9d71a9625 (patch) | |
| tree | 641291b47601bd85d6a1ce2489febaca74b98d9d | |
| parent | virtio: add features as qdev properties (diff) | |
| download | qemu-49e75cf38848e6da70c0e9ddb4d994e9d71a9625.tar.gz qemu-49e75cf38848e6da70c0e9ddb4d994e9d71a9625.tar.xz qemu-49e75cf38848e6da70c0e9ddb4d994e9d71a9625.zip | |
virtio-pci: thinko fix
Since patch ed757e140c0ada220f213036e4497315d24ca8bct, virtio will
sometimes clear all status registers on bus master disable, which loses
information such as VIRTIO_CONFIG_S_FAILED bit. This is a result of
a patch being misapplied: code uses ! instead of ~ for bit
operations as in Yan's original patch. This obviously does not make
sense.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
| -rw-r--r-- | hw/virtio-pci.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c index 6d0f9dd37a..573c98a08b 100644 --- a/hw/virtio-pci.c +++ b/hw/virtio-pci.c @@ -374,7 +374,7 @@ static void virtio_write_config(PCIDevice *pci_dev, uint32_t address, if (PCI_COMMAND == address) { if (!(val & PCI_COMMAND_MASTER)) { - proxy->vdev->status &= !VIRTIO_CONFIG_S_DRIVER_OK; + proxy->vdev->status &= ~VIRTIO_CONFIG_S_DRIVER_OK; } } |