diff options
| author | Fabiano Rosas | 2018-03-12 23:07:50 +0100 |
|---|---|---|
| committer | Kevin Wolf | 2018-03-26 12:16:00 +0200 |
| commit | 65d2c3e2f64b116f6a25d38cde5919d38f36d26d (patch) | |
| tree | aa1a548f8da914293d62f0b0fcfea8b6942c58af | |
| parent | block/replication: Remove protocol_name field (diff) | |
| download | qemu-65d2c3e2f64b116f6a25d38cde5919d38f36d26d.tar.gz qemu-65d2c3e2f64b116f6a25d38cde5919d38f36d26d.tar.xz qemu-65d2c3e2f64b116f6a25d38cde5919d38f36d26d.zip | |
block/quorum: Remove protocol-related fields
The quorum driver is not a protocol so it should implement bdrv_open
instead of bdrv_file_open and not provide a protocol_name.
Attempts to invoke this driver using protocol syntax
(i.e. quorum:<filename:options:...>) will now fail gracefully:
$ qemu-img info quorum:foo
qemu-img: Could not open 'quorum:foo': Unknown protocol 'quorum'
Signed-off-by: Fabiano Rosas <farosas@linux.vnet.ibm.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
| -rw-r--r-- | block/quorum.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/block/quorum.c b/block/quorum.c index 14333c18aa..cfe484a945 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -1098,11 +1098,10 @@ static void quorum_refresh_filename(BlockDriverState *bs, QDict *options) static BlockDriver bdrv_quorum = { .format_name = "quorum", - .protocol_name = "quorum", .instance_size = sizeof(BDRVQuorumState), - .bdrv_file_open = quorum_open, + .bdrv_open = quorum_open, .bdrv_close = quorum_close, .bdrv_refresh_filename = quorum_refresh_filename, |