diff options
| author | Lukas Straub | 2021-03-18 05:11:52 +0100 |
|---|---|---|
| committer | Jason Wang | 2021-03-22 10:34:31 +0100 |
| commit | 739128e43b6da3d0a48ec8551d94909dc5a8f3bc (patch) | |
| tree | 9dadaa4fbf3fbd4afdb0cabe606a010cd11a2551 | |
| parent | net/colo-compare.c: Fix memory leak for non-tcp packet (diff) | |
| download | qemu-739128e43b6da3d0a48ec8551d94909dc5a8f3bc.tar.gz qemu-739128e43b6da3d0a48ec8551d94909dc5a8f3bc.tar.xz qemu-739128e43b6da3d0a48ec8551d94909dc5a8f3bc.zip | |
net/colo-compare.c: Optimize removal of secondary packet
g_queue_remove needs to look up the list entry first, but we
already have it as result and can remove it directly with
g_queue_delete_link.
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Signed-off-by: Zhang Chen <chen.zhang@intel.com>
Reviewed-by: Zhang Chen <chen.zhang@intel.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
| -rw-r--r-- | net/colo-compare.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/colo-compare.c b/net/colo-compare.c index 2e819ffedb..9d1ad99941 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@ -691,7 +691,7 @@ static void colo_compare_packet(CompareState *s, Connection *conn, if (result) { colo_release_primary_pkt(s, pkt); packet_destroy(result->data, NULL); - g_queue_remove(&conn->secondary_list, result->data); + g_queue_delete_link(&conn->secondary_list, result); } else { /* * If one packet arrive late, the secondary_list or |