diff options
| author | Michael S. Tsirkin | 2017-01-24 18:03:40 +0100 |
|---|---|---|
| committer | Michael S. Tsirkin | 2017-02-01 02:37:18 +0100 |
| commit | d56ec1e98c0005933fe677d633484297f422691a (patch) | |
| tree | 3d7ad387f92654b107f6618016b48dd0bbae0713 | |
| parent | virtio: make virtio_should_notify static (diff) | |
| download | qemu-d56ec1e98c0005933fe677d633484297f422691a.tar.gz qemu-d56ec1e98c0005933fe677d633484297f422691a.tar.xz qemu-d56ec1e98c0005933fe677d633484297f422691a.zip | |
vhost: skip ROM sections
vhost does not support RO protections on memory at the moment - adding
ROMs would mean that e.g. a buggy guest might change them in-memory - a
condition from which guest reset does not recover. Not nice.
We also definitely don't want to try logging writes into ROMs -
in particular guests set very high addresses for ROM BARs
so logging these writes would waste a lot of memory.
Maybe ROMs could be supported with the iotlb variant -
not sure, but there seems to be no good reason for virtio
to try to do DMA from ROM. So let's just skip ROM memory.
Suggested-by: Laurent Vivier <lvivier@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
Tested-by: Laurent Vivier <lvivier@redhat.com>
| -rw-r--r-- | hw/virtio/vhost.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index b124d97d7c..febe519bbd 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@ -612,7 +612,8 @@ static void vhost_set_memory(MemoryListener *listener, static bool vhost_section(MemoryRegionSection *section) { - return memory_region_is_ram(section->mr); + return memory_region_is_ram(section->mr) && + !memory_region_is_rom(section->mr); } static void vhost_begin(MemoryListener *listener) |