diff options
| author | Vladimir Sementsov-Ogievskiy | 2021-04-28 17:17:31 +0200 |
|---|---|---|
| committer | Kevin Wolf | 2021-04-30 12:27:47 +0200 |
| commit | 397f7cc0c217cfe45f42ee21e2ad5b84f3333b67 (patch) | |
| tree | c5ab18e8d0eff94a46db4e90107658c25d9fe79e /block/commit.c | |
| parent | tests/test-bdrv-graph-mod: add test_parallel_perm_update (diff) | |
| download | qemu-397f7cc0c217cfe45f42ee21e2ad5b84f3333b67.tar.gz qemu-397f7cc0c217cfe45f42ee21e2ad5b84f3333b67.tar.xz qemu-397f7cc0c217cfe45f42ee21e2ad5b84f3333b67.zip | |
tests/test-bdrv-graph-mod: add test_append_greedy_filter
bdrv_append() is not quite good for inserting filters: it does extra
permission update in intermediate state, where filter get it filtered
child but is not yet replace it in a backing chain.
Some filters (for example backup-top) may want permissions even when
have no parents. And described intermediate state becomes invalid.
That's (half a) reason, why we need "inactive" state for backup-top
filter.
bdrv_append() will be improved later, now let's add a unit test.
Now test fails, so it runs only with -d flag. To run do
./test-bdrv-graph-mod -d -p /bdrv-graph-mod/append-greedy-filter
from <build-directory>/tests.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20210428151804.439460-4-vsementsov@virtuozzo.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'block/commit.c')
0 files changed, 0 insertions, 0 deletions