diff options
| author | Eric Blake | 2020-04-28 21:26:46 +0200 |
|---|---|---|
| committer | Max Reitz | 2020-05-05 13:17:36 +0200 |
| commit | a3aeeab557f08285c4fcf537fca575b069eb67ef (patch) | |
| tree | c7baa354e4f6b9bd1d62f570c2da8cb84e6397c5 /block/vmdk.c | |
| parent | iotests: use python logging for iotests.log() (diff) | |
| download | qemu-a3aeeab557f08285c4fcf537fca575b069eb67ef.tar.gz qemu-a3aeeab557f08285c4fcf537fca575b069eb67ef.tar.xz qemu-a3aeeab557f08285c4fcf537fca575b069eb67ef.zip | |
block: Add blk_new_with_bs() helper
There are several callers that need to create a new block backend from
an existing BDS; make the task slightly easier with a common helper
routine.
Suggested-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200424190903.522087-2-eblake@redhat.com>
[mreitz: Set @ret only in error paths, see
https://lists.nongnu.org/archive/html/qemu-block/2020-04/msg01216.html]
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20200428192648.749066-2-eblake@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
Diffstat (limited to 'block/vmdk.c')
| -rw-r--r-- | block/vmdk.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/block/vmdk.c b/block/vmdk.c index 8ec18f35a5..b02fdd14b2 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -2717,11 +2717,10 @@ static BlockBackend *vmdk_co_create_cb(int64_t size, int idx, if (!bs) { return NULL; } - blk = blk_new(bdrv_get_aio_context(bs), - BLK_PERM_CONSISTENT_READ | BLK_PERM_WRITE | BLK_PERM_RESIZE, - BLK_PERM_ALL); - if (blk_insert_bs(blk, bs, errp)) { - bdrv_unref(bs); + blk = blk_new_with_bs(bs, + BLK_PERM_CONSISTENT_READ | BLK_PERM_WRITE | BLK_PERM_RESIZE, + BLK_PERM_ALL, errp); + if (!blk) { return NULL; } blk_set_allow_write_beyond_eof(blk, true); |