diff options
| author | Paolo Bonzini | 2015-05-28 16:21:43 +0200 |
|---|---|---|
| committer | Jeff Cody | 2015-07-15 03:50:13 +0200 |
| commit | 299bf097375f9d148cda579ad85477304e38856b (patch) | |
| tree | bc3606a6be812dd68f6d48846b95d0de8b0e840c /blockdev.c | |
| parent | block/mirror: Sleep periodically during bitmap scanning (diff) | |
| download | qemu-299bf097375f9d148cda579ad85477304e38856b.tar.gz qemu-299bf097375f9d148cda579ad85477304e38856b.tar.xz qemu-299bf097375f9d148cda579ad85477304e38856b.zip | |
blockdev: no need to drain in qmp_block_commit
Draining is not necessary, I/O can happen as soon as the
commit coroutine yields. Draining can be necessary before
reopening the file for read/write, or while modifying the
backing file chain, but that is done separately in
bdrv_reopen_multiple or bdrv_close; this particular
bdrv_drain_all does nothing for that.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 1432822903-25821-1-git-send-email-pbonzini@redhat.com
Signed-off-by: Jeff Cody <jcody@redhat.com>
Diffstat (limited to 'blockdev.c')
| -rw-r--r-- | blockdev.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/blockdev.c b/blockdev.c index 7fee519a1c..50421c8b98 100644 --- a/blockdev.c +++ b/blockdev.c @@ -2380,9 +2380,6 @@ void qmp_block_commit(const char *device, aio_context = bdrv_get_aio_context(bs); aio_context_acquire(aio_context); - /* drain all i/o before commits */ - bdrv_drain_all(); - if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_COMMIT_SOURCE, errp)) { goto out; } |