diff options
| author | Alex Bennée | 2017-04-05 13:35:48 +0200 |
|---|---|---|
| committer | Alex Bennée | 2017-04-10 11:23:38 +0200 |
| commit | eda5f7c6a147c8eb927a6198ec48fe677cb079b3 (patch) | |
| tree | aa79ed0426be8641ed4aefc8335115c0a5165a71 /cpu-exec.c | |
| parent | cpus: introduce cpu_update_icount helper (diff) | |
| download | qemu-eda5f7c6a147c8eb927a6198ec48fe677cb079b3.tar.gz qemu-eda5f7c6a147c8eb927a6198ec48fe677cb079b3.tar.xz qemu-eda5f7c6a147c8eb927a6198ec48fe677cb079b3.zip | |
cpu-exec: update icount after each TB_EXIT
There is no particular reason we shouldn't update the global system
icount time as we exit each TranslationBlock run. This ensures the
main-loop doesn't have to wait until we exit to the outer loop for
executed instructions to be credited to timer_state.
The prepare_icount_for_run function is slightly tweaked to match the
logic we run in cpu_loop_exec_tb.
Based on Paolo's original suggestion.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Diffstat (limited to 'cpu-exec.c')
| -rw-r--r-- | cpu-exec.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/cpu-exec.c b/cpu-exec.c index 748cb66bca..63a56d0407 100644 --- a/cpu-exec.c +++ b/cpu-exec.c @@ -600,13 +600,13 @@ static inline void cpu_loop_exec_tb(CPUState *cpu, TranslationBlock *tb, /* Instruction counter expired. */ assert(use_icount); #ifndef CONFIG_USER_ONLY - if (cpu->icount_extra) { - /* Refill decrementer and continue execution. */ - cpu->icount_extra += insns_left; - insns_left = MIN(0xffff, cpu->icount_extra); - cpu->icount_extra -= insns_left; - cpu->icount_decr.u16.low = insns_left; - } else { + /* Ensure global icount has gone forward */ + cpu_update_icount(cpu); + /* Refill decrementer and continue execution. */ + insns_left = MIN(0xffff, cpu->icount_budget); + cpu->icount_decr.u16.low = insns_left; + cpu->icount_extra = cpu->icount_budget - insns_left; + if (!cpu->icount_extra) { /* Execute any remaining instructions, then let the main loop * handle the next event. */ |