diff options
| author | Cao jin | 2016-09-12 08:34:56 +0200 |
|---|---|---|
| committer | Paolo Bonzini | 2016-09-13 19:09:43 +0200 |
| commit | c2cd627ddb13f62557aaf66305edb03cc3d9612d (patch) | |
| tree | 371e69422977c0c55d704199f10274c87a10562f /exec.c | |
| parent | i8257: Make device "i8257" unavailable with -device (diff) | |
| download | qemu-c2cd627ddb13f62557aaf66305edb03cc3d9612d.tar.gz qemu-c2cd627ddb13f62557aaf66305edb03cc3d9612d.tar.xz qemu-c2cd627ddb13f62557aaf66305edb03cc3d9612d.zip | |
kvm-all: drop kvm_setup_guest_memory
kvm_setup_guest_memory only does "madvise to QEMU_MADV_DONTFORK" and
is only called by ram_block_add, which actually is duplicate code.
Bonus: add simple comment for kvm_has_sync_mmu to make life easier.
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
Message-Id: <1473662096-32598-1-git-send-email-caoj.fnst@cn.fujitsu.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'exec.c')
| -rw-r--r-- | exec.c | 4 |
1 files changed, 1 insertions, 3 deletions
@@ -1621,10 +1621,8 @@ static void ram_block_add(RAMBlock *new_block, Error **errp) if (new_block->host) { qemu_ram_setup_dump(new_block->host, new_block->max_length); qemu_madvise(new_block->host, new_block->max_length, QEMU_MADV_HUGEPAGE); + /* MADV_DONTFORK is also needed by KVM in absence of synchronous MMU */ qemu_madvise(new_block->host, new_block->max_length, QEMU_MADV_DONTFORK); - if (kvm_enabled()) { - kvm_setup_guest_memory(new_block->host, new_block->max_length); - } } } |