diff options
| author | Eric Blake | 2018-01-25 15:45:57 +0100 |
|---|---|---|
| committer | Eric Blake | 2018-01-26 16:56:12 +0100 |
| commit | 08fb10a7292637eb5836b8ac07b7ef8267db03be (patch) | |
| tree | 30550b8a851e2be1eb5f9a4f2ff28c6e259b5b4a /hmp.c | |
| parent | iotest 205: new test for qmp nbd-server-remove (diff) | |
| download | qemu-08fb10a7292637eb5836b8ac07b7ef8267db03be.tar.gz qemu-08fb10a7292637eb5836b8ac07b7ef8267db03be.tar.xz qemu-08fb10a7292637eb5836b8ac07b7ef8267db03be.zip | |
hmp: Add nbd_server_remove to mirror QMP command
Since everything else about the nbd-server-* QMP commands is
accessible from HMP, we might as well make removing an export
available as well. For now, I went with a bool flag rather
than a mode string for choosing between safe (default) and
hard modes.
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20180125144557.25502-1-eblake@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
Diffstat (limited to 'hmp.c')
| -rw-r--r-- | hmp.c | 14 |
1 files changed, 11 insertions, 3 deletions
@@ -2226,10 +2226,18 @@ void hmp_nbd_server_add(Monitor *mon, const QDict *qdict) Error *local_err = NULL; qmp_nbd_server_add(device, !!name, name, true, writable, &local_err); + hmp_handle_error(mon, &local_err); +} - if (local_err != NULL) { - hmp_handle_error(mon, &local_err); - } +void hmp_nbd_server_remove(Monitor *mon, const QDict *qdict) +{ + const char *name = qdict_get_str(qdict, "name"); + bool force = qdict_get_try_bool(qdict, "force", false); + Error *err = NULL; + + /* Rely on NBD_SERVER_REMOVE_MODE_SAFE being the default */ + qmp_nbd_server_remove(name, force, NBD_SERVER_REMOVE_MODE_HARD, &err); + hmp_handle_error(mon, &err); } void hmp_nbd_server_stop(Monitor *mon, const QDict *qdict) |