summaryrefslogtreecommitdiffstats
path: root/hw/display/pl110.c
diff options
context:
space:
mode:
authorIgor Mammedov2020-08-21 12:05:19 +0200
committerEduardo Habkost2020-08-27 19:54:37 +0200
commitfadb055bd4abcb3f356854742c1493560a7d136e (patch)
treefcbdab66a5603e787dc023c67e4f011f9e19a773 /hw/display/pl110.c
parentMerge remote-tracking branch 'remotes/cohuck/tags/s390x-20200827' into staging (diff)
downloadqemu-fadb055bd4abcb3f356854742c1493560a7d136e.tar.gz
qemu-fadb055bd4abcb3f356854742c1493560a7d136e.tar.xz
qemu-fadb055bd4abcb3f356854742c1493560a7d136e.zip
numa: hmat: fix cache size check
when QEMU is started like: qemu-system-x86_64 -smp 2 -machine hmat=on \ -m 2G \ -object memory-backend-ram,size=1G,id=m0 \ -object memory-backend-ram,size=1G,id=m1 \ -numa node,nodeid=0,memdev=m0 \ -numa node,nodeid=1,memdev=m1,initiator=0 \ -numa cpu,node-id=0,socket-id=0 \ -numa cpu,node-id=0,socket-id=1 \ -numa hmat-lb,initiator=0,target=0,hierarchy=memory,data-type=access-latency,latency=5 \ -numa hmat-lb,initiator=0,target=0,hierarchy=memory,data-type=access-bandwidth,bandwidth=200M \ -numa hmat-lb,initiator=0,target=1,hierarchy=memory,data-type=access-latency,latency=10 \ -numa hmat-lb,initiator=0,target=1,hierarchy=memory,data-type=access-bandwidth,bandwidth=100M \ -numa hmat-cache,node-id=0,size=8K,level=1,associativity=direct,policy=write-back,line=5 \ -numa hmat-cache,node-id=0,size=16K,level=2,associativity=direct,policy=write-back,line=5 it errors out with: -numa hmat-cache,node-id=0,size=16K,level=2,associativity=direct,policy=write-back,line=5: Invalid size=16384, the size of level=2 should be less than the size(8192) of level=1 which doesn't look right as one would expect that L1 < L2 < L3 ... Fix it by sawpping relevant size checks. Fixes: c412a48d4d91 (numa: Extend CLI to provide memory side cache information) Signed-off-by: Igor Mammedov <imammedo@redhat.com> Message-Id: <20200821100519.1325691-1-imammedo@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Diffstat (limited to 'hw/display/pl110.c')
0 files changed, 0 insertions, 0 deletions