diff options
author | Eryu Guan | 2020-01-07 05:15:21 +0100 |
---|---|---|
committer | Dr. David Alan Gilbert | 2020-01-23 17:41:37 +0100 |
commit | 9883df8ccae6d744a0c8d9cbf9d62b1797d70ebd (patch) | |
tree | 4023a1c12817ad1687fd8f1f940bacdd79619caa /hw/display/virtio-vga.c | |
parent | virtiofsd/passthrough_ll: Pass errno to fuse_reply_err() (diff) | |
download | qemu-9883df8ccae6d744a0c8d9cbf9d62b1797d70ebd.tar.gz qemu-9883df8ccae6d744a0c8d9cbf9d62b1797d70ebd.tar.xz qemu-9883df8ccae6d744a0c8d9cbf9d62b1797d70ebd.zip |
virtiofsd: stop all queue threads on exit in virtio_loop()
On guest graceful shutdown, virtiofsd receives VHOST_USER_GET_VRING_BASE
request from VMM and shuts down virtqueues by calling fv_set_started(),
which joins fv_queue_thread() threads. So when virtio_loop() returns,
there should be no thread is still accessing data in fuse session and/or
virtio dev.
But on abnormal exit, e.g. guest got killed for whatever reason,
vhost-user socket is closed and virtio_loop() breaks out the main loop
and returns to main(). But it's possible fv_queue_worker()s are still
working and accessing fuse session and virtio dev, which results in
crash or use-after-free.
Fix it by stopping fv_queue_thread()s before virtio_loop() returns,
to make sure there's no-one could access fuse session and virtio dev.
Reported-by: Qingming Su <qingming.su@linux.alibaba.com>
Signed-off-by: Eryu Guan <eguan@linux.alibaba.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Diffstat (limited to 'hw/display/virtio-vga.c')
0 files changed, 0 insertions, 0 deletions