diff options
author | Markus Armbruster | 2014-04-25 12:44:22 +0200 |
---|---|---|
committer | Andreas Färber | 2014-05-05 19:08:49 +0200 |
commit | 65cd9064e13f2388d3bd9c815826f5db6b0b13ec (patch) | |
tree | 1a0c27b53afbf5924ffb08482fff7d2f3732c520 /hw/intc/arm_gic.c | |
parent | hw: Consistently name Error ** objects errp, and not err (diff) | |
download | qemu-65cd9064e13f2388d3bd9c815826f5db6b0b13ec.tar.gz qemu-65cd9064e13f2388d3bd9c815826f5db6b0b13ec.tar.xz qemu-65cd9064e13f2388d3bd9c815826f5db6b0b13ec.zip |
qom: Clean up fragile use of error_is_set() in set() methods
Using error_is_set(ERRP) to find out whether a function failed is
either wrong, fragile, or unnecessarily opaque. It's wrong when ERRP
may be null, because errors go undetected when it is. It's fragile
when proving ERRP non-null involves a non-local argument. Else, it's
unnecessarily opaque (see commit 84d18f0).
I guess the error_is_set(errp) in the ObjectProperty set() methods are
merely fragile right now, because I can't find a call chain that
passes a null errp argument.
Make the code more robust and more obviously correct: receive the
error in a local variable, then propagate it through the parameter.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
Diffstat (limited to 'hw/intc/arm_gic.c')
0 files changed, 0 insertions, 0 deletions