diff options
| author | Paolo Bonzini | 2013-04-08 15:03:15 +0200 |
|---|---|---|
| committer | Anthony Liguori | 2013-04-08 17:38:41 +0200 |
| commit | 1e885b25275fb6763eb947b1e53b2d6911b967a8 (patch) | |
| tree | aaf5aace44cbabf2b71d4b7219bce47f622e6cf9 /hw/pci-host/ppce500.c | |
| parent | Merge remote-tracking branch 'mdroth/qga-pull-4-2-13' into staging (diff) | |
| download | qemu-1e885b25275fb6763eb947b1e53b2d6911b967a8.tar.gz qemu-1e885b25275fb6763eb947b1e53b2d6911b967a8.tar.xz qemu-1e885b25275fb6763eb947b1e53b2d6911b967a8.zip | |
qemu-char: really fix behavior on can_read = 0
I misread the glib manual, g_source_remove does not let you re-attach
the source later. This behavior (called "blocking" the source in glib)
is present in glib's source code, but private and not available outside
glib; hence, we have to resort to re-creating the source every time.
In fact, g_source_remove and g_source_destroy are the same thing,
except g_source_destroy is O(1) while g_source_remove scans a potentially
very long list of GSources in the current main loop. Ugh. Better
use g_source_destroy explicitly, and leave "tags" to those dummies who
cannot track their pointers' lifetimes.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-id: 1365426195-12596-1-git-send-email-pbonzini@redhat.com
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Diffstat (limited to 'hw/pci-host/ppce500.c')
0 files changed, 0 insertions, 0 deletions