diff options
| author | Isaku Yamahata | 2010-11-26 13:01:41 +0100 |
|---|---|---|
| committer | Michael S. Tsirkin | 2010-12-09 11:47:48 +0100 |
| commit | b1aeb92666d2fde413c34578b3b42bbfe5f2a506 (patch) | |
| tree | f29a9326008c68ca7c1a762f7f3f6e97832bef7e /hw/pci.c | |
| parent | virtio-net: stop/start bh when appropriate (diff) | |
| download | qemu-b1aeb92666d2fde413c34578b3b42bbfe5f2a506.tar.gz qemu-b1aeb92666d2fde413c34578b3b42bbfe5f2a506.tar.xz qemu-b1aeb92666d2fde413c34578b3b42bbfe5f2a506.zip | |
pci: make command SERR bit writable
pcie aer needs SERR bit to be writable, and the PCI spec requires
this as well. For compatibility, introduce compat global property
command_serr_enable and make this bit readonly for a pre 0.14 pc
machine.
Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'hw/pci.c')
| -rw-r--r-- | hw/pci.c | 5 |
1 files changed, 5 insertions, 0 deletions
@@ -57,6 +57,8 @@ struct BusInfo pci_bus_info = { DEFINE_PROP_UINT32("rombar", PCIDevice, rom_bar, 1), DEFINE_PROP_BIT("multifunction", PCIDevice, cap_present, QEMU_PCI_CAP_MULTIFUNCTION_BITNR, false), + DEFINE_PROP_BIT("command_serr_enable", PCIDevice, cap_present, + QEMU_PCI_CAP_SERR_BITNR, true), DEFINE_PROP_END_OF_LIST() } }; @@ -568,6 +570,9 @@ static void pci_init_wmask(PCIDevice *dev) pci_set_word(dev->wmask + PCI_COMMAND, PCI_COMMAND_IO | PCI_COMMAND_MEMORY | PCI_COMMAND_MASTER | PCI_COMMAND_INTX_DISABLE); + if (dev->cap_present & QEMU_PCI_CAP_SERR) { + pci_word_test_and_set_mask(dev->wmask + PCI_COMMAND, PCI_COMMAND_SERR); + } memset(dev->wmask + PCI_CONFIG_HEADER_SIZE, 0xff, config_size - PCI_CONFIG_HEADER_SIZE); |