diff options
| author | Markus Armbruster | 2020-12-11 18:11:39 +0100 |
|---|---|---|
| committer | Markus Armbruster | 2020-12-19 10:38:43 +0100 |
| commit | bce800869b44ce82705205147018bffbbc798834 (patch) | |
| tree | 8bbb2029f5cf60bc3019650ab9a30508674e85b8 /hw/rdma/rdma_backend_defs.h | |
| parent | Revert "qstring: add qstring_free()" (diff) | |
| download | qemu-bce800869b44ce82705205147018bffbbc798834.tar.gz qemu-bce800869b44ce82705205147018bffbbc798834.tar.xz qemu-bce800869b44ce82705205147018bffbbc798834.zip | |
hw/rdma: Replace QList by GQueue
RdmaProtectedQList provides a thread-safe queue of int64_t on top of a
QList.
rdma_protected_qlist_destroy() calls qlist_destroy_obj() directly.
qlist_destroy_obj() is actually for use by qobject_destroy() only.
The next commit will make that obvious.
The minimal fix would be calling qobject_unref() instead. But QList
is actually a bad fit here. It's designed for representing JSON
arrays. We're better off with a GQueue here. Replace.
Cc: Yuval Shaia <yuval.shaia.ml@gmail.com>
Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20201211171152.146877-8-armbru@redhat.com>
Diffstat (limited to 'hw/rdma/rdma_backend_defs.h')
| -rw-r--r-- | hw/rdma/rdma_backend_defs.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/rdma/rdma_backend_defs.h b/hw/rdma/rdma_backend_defs.h index 0b55be3503..4e6c0ad695 100644 --- a/hw/rdma/rdma_backend_defs.h +++ b/hw/rdma/rdma_backend_defs.h @@ -43,7 +43,7 @@ typedef struct RdmaBackendDev { struct ibv_context *context; struct ibv_comp_channel *channel; uint8_t port_num; - RdmaProtectedQList recv_mads_list; + RdmaProtectedGQueue recv_mads_list; RdmaCmMux rdmacm_mux; } RdmaBackendDev; |