diff options
author | Alex Williamson | 2017-12-13 18:19:32 +0100 |
---|---|---|
committer | Alex Williamson | 2017-12-13 18:19:32 +0100 |
commit | 2016986aedb6ea2839662eb5f60630f3e231bd1a (patch) | |
tree | 2921a726ad008d7c6996512ef14d80e532a92607 /hw/vfio/pci.h | |
parent | Update version for v2.11.0 release (diff) | |
download | qemu-2016986aedb6ea2839662eb5f60630f3e231bd1a.tar.gz qemu-2016986aedb6ea2839662eb5f60630f3e231bd1a.tar.xz qemu-2016986aedb6ea2839662eb5f60630f3e231bd1a.zip |
vfio: Fix vfio-kvm group registration
Commit 8c37faa475f3 ("vfio-pci, ppc64/spapr: Reorder group-to-container
attaching") moved registration of groups with the vfio-kvm device from
vfio_get_group() to vfio_connect_container(), but it missed the case
where a group is attached to an existing container and takes an early
exit. Perhaps this is a less common case on ppc64/spapr, but on x86
(without viommu) all groups are connected to the same container and
thus only the first group gets registered with the vfio-kvm device.
This becomes a problem if we then hot-unplug the devices associated
with that first group and we end up with KVM being misinformed about
any vfio connections that might remain. Fix by including the call to
vfio_kvm_device_add_group() in this early exit path.
Fixes: 8c37faa475f3 ("vfio-pci, ppc64/spapr: Reorder group-to-container attaching")
Cc: qemu-stable@nongnu.org # qemu-2.10+
Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Reviewed-by: Peter Xu <peterx@redhat.com>
Tested-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Tested-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Diffstat (limited to 'hw/vfio/pci.h')
0 files changed, 0 insertions, 0 deletions