diff options
| author | Stefan Hajnoczi | 2016-09-21 17:52:23 +0200 |
|---|---|---|
| committer | Michael S. Tsirkin | 2016-09-23 18:03:56 +0200 |
| commit | b1c7c07f2db2096451791882e9d1cdc301b66cdb (patch) | |
| tree | bbfc6e4fd057f5be8959457d843ce7db9336d775 /hw | |
| parent | virtio: handle virtqueue_get_avail_bytes() errors (diff) | |
| download | qemu-b1c7c07f2db2096451791882e9d1cdc301b66cdb.tar.gz qemu-b1c7c07f2db2096451791882e9d1cdc301b66cdb.tar.xz qemu-b1c7c07f2db2096451791882e9d1cdc301b66cdb.zip | |
virtio: use unsigned int for virtqueue_get_avail_bytes() index
The virtio code uses int, unsigned int, and uint16_t for virtqueue
indices. The uint16_t is used for the low-level descriptor layout in
virtio_ring.h while code that isn't concerned with descriptor layout can
use unsigned int.
Use of int is problematic because it can result in signed/unsigned
comparison and incompatible int*/unsigned int* pointer types.
Make the virtqueue_get_avail_bytes() 'i' variable unsigned int. This
eliminates the need to introduce casts and modify code further in the
patches that follow.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Diffstat (limited to 'hw')
| -rw-r--r-- | hw/virtio/virtio.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 10c2f3d7a4..973d0c2228 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -416,7 +416,7 @@ void virtqueue_get_avail_bytes(VirtQueue *vq, unsigned int *in_bytes, unsigned int max, num_bufs, indirect = 0; VRingDesc desc; hwaddr desc_pa; - int i; + unsigned int i; max = vq->vring.num; num_bufs = total_bufs; |