diff options
author | Philippe Mathieu-Daudé | 2020-08-28 11:02:46 +0200 |
---|---|---|
committer | Peter Maydell | 2020-08-28 11:02:46 +0200 |
commit | 739fa3255492f1c7541db1c7a9795fcf4b472c91 (patch) | |
tree | 66fd7f9d85ea237f11df037bd0b0344365c63ce2 /include/hw/misc/unimp.h | |
parent | hw/qdev-clock: Uninline qdev_connect_clock_in() (diff) | |
download | qemu-739fa3255492f1c7541db1c7a9795fcf4b472c91.tar.gz qemu-739fa3255492f1c7541db1c7a9795fcf4b472c91.tar.xz qemu-739fa3255492f1c7541db1c7a9795fcf4b472c91.zip |
hw/qdev-clock: Avoid calling qdev_connect_clock_in after DeviceRealize
Clock canonical name is set in device_set_realized (see the block
added to hw/core/qdev.c in commit 0e6934f264).
If we connect a clock after the device is realized, this code is
not executed. This is currently not a problem as this name is only
used for trace events, however this disrupt tracing.
Add a comment to document qdev_connect_clock_in() must be called
before the device is realized, and assert this condition.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-id: 20200803105647.22223-5-f4bug@amsat.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Diffstat (limited to 'include/hw/misc/unimp.h')
0 files changed, 0 insertions, 0 deletions