diff options
| author | Zhi Hui Li | 2011-11-24 09:27:52 +0100 |
|---|---|---|
| committer | Stefan Hajnoczi | 2011-12-06 10:56:41 +0100 |
| commit | 91a9ecefb6d7f066c6eecc09f7231ce7969d1817 (patch) | |
| tree | b9b6aa6d2ec6f6cb539fa2caebc7da0bf07a4b00 /linux-user | |
| parent | net/socket.c : fix memory leak (diff) | |
| download | qemu-91a9ecefb6d7f066c6eecc09f7231ce7969d1817.tar.gz qemu-91a9ecefb6d7f066c6eecc09f7231ce7969d1817.tar.xz qemu-91a9ecefb6d7f066c6eecc09f7231ce7969d1817.zip | |
win32: fix memory leak
string is allocated by g_malloc, will not be used after putenv, should be
free before return.
Paolo Bonzini <pbonzini@redhat.com> confirmed this is safe under Wine:
"1) the underlying Win32 APIs require separate arguments for the
variable and value; 2) even though in the end Wine stores the
environment as name=value
(http://source.winehq.org/source/dlls/ntdll/env.c), it does so in a
single consecutive block of memory, not as a char* array like POSIX
does. While (2) might apply only to Wine, (1) surely applies to Windows
as well."
Tested-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Li Zhi Hui <zhihuili@linux.vnet.ibm.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Diffstat (limited to 'linux-user')
0 files changed, 0 insertions, 0 deletions