diff options
| author | Paolo Bonzini | 2013-01-25 14:12:37 +0100 |
|---|---|---|
| committer | Anthony Liguori | 2013-02-01 22:53:11 +0100 |
| commit | b09995aef1d4a5879000a196a82e37b0511c8e03 (patch) | |
| tree | 5e9019b61486cb07a7707633f209fa630863dc7d /linux-user | |
| parent | qdev: inline object_delete into qbus_free/qdev_free (diff) | |
| download | qemu-b09995aef1d4a5879000a196a82e37b0511c8e03.tar.gz qemu-b09995aef1d4a5879000a196a82e37b0511c8e03.tar.xz qemu-b09995aef1d4a5879000a196a82e37b0511c8e03.zip | |
qdev: drop extra references at creation time
qdev_free and qbus_free have to do unparent+unref, because nobody else
drops the initial reference (the one included by object_initialize)
before them.
For device_init_func and do_device_add, this is trivially correct,
since the DeviceState goes out of scope.
For qdev_create, qdev_try_create and qbus_init, it is a bit more tricky.
What we are doing here is just assuming that the caller knows what it's
doing, and won't call qdev_free/qbus_free while the device is still there.
This is a pretty reasonable assumption and (behind the scenes) is also
what GObject/GTK does. GTK actually has a "floating reference" that
goes away as soon as the caller does gtk_container_add or something
like that, but in the end qbus_init and qdev_try_create are already
adding the new object to its qdev parent! So in the end the two solutions
are the same.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Diffstat (limited to 'linux-user')
0 files changed, 0 insertions, 0 deletions
