diff options
| author | Eric Blake | 2016-01-29 14:48:59 +0100 |
|---|---|---|
| committer | Markus Armbruster | 2016-02-08 17:29:57 +0100 |
| commit | 08f9541dec51700abef0c37994213164ca4e4fc9 (patch) | |
| tree | 2fbddce86ad35307b616aca8e795965e862b779f /qapi/opts-visitor.c | |
| parent | qapi: Tighten qmp_input_end_list() (diff) | |
| download | qemu-08f9541dec51700abef0c37994213164ca4e4fc9.tar.gz qemu-08f9541dec51700abef0c37994213164ca4e4fc9.tar.xz qemu-08f9541dec51700abef0c37994213164ca4e4fc9.zip | |
qapi: Drop unused error argument for list and implicit struct
No backend was setting an error when ending the visit of a list or
implicit struct, or when moving to the next list node. Make the
callers a bit easier to follow by making this a part of the contract,
and removing the errp argument - callers can then unconditionally end
an object as part of cleanup without having to think about whether a
second error is dominated by a first, because there is no second
error.
A later patch will then tackle the larger task of splitting
visit_end_struct(), which can indeed set an error.
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <1454075341-13658-24-git-send-email-eblake@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'qapi/opts-visitor.c')
| -rw-r--r-- | qapi/opts-visitor.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c index d1c0c5abf7..d54f75b5e7 100644 --- a/qapi/opts-visitor.c +++ b/qapi/opts-visitor.c @@ -1,7 +1,7 @@ /* * Options Visitor * - * Copyright Red Hat, Inc. 2012, 2013 + * Copyright Red Hat, Inc. 2012-2016 * * Author: Laszlo Ersek <lersek@redhat.com> * @@ -221,7 +221,7 @@ opts_start_list(Visitor *v, const char *name, Error **errp) static GenericList * -opts_next_list(Visitor *v, GenericList **list, Error **errp) +opts_next_list(Visitor *v, GenericList **list) { OptsVisitor *ov = to_ov(v); GenericList **link; @@ -270,7 +270,7 @@ opts_next_list(Visitor *v, GenericList **list, Error **errp) static void -opts_end_list(Visitor *v, Error **errp) +opts_end_list(Visitor *v) { OptsVisitor *ov = to_ov(v); |