diff options
| author | Michael Roth | 2011-09-15 21:39:52 +0200 |
|---|---|---|
| committer | Luiz Capitulino | 2011-10-04 16:00:46 +0200 |
| commit | 5666dd19dd95d966be00d0c3e7efdfaecc096ff3 (patch) | |
| tree | 034ac3fd5d50ef4058c58e879e5aceba327ecab4 /qapi/qmp-output-visitor.h | |
| parent | qapi: fixup command generation for functions that return list types (diff) | |
| download | qemu-5666dd19dd95d966be00d0c3e7efdfaecc096ff3.tar.gz qemu-5666dd19dd95d966be00d0c3e7efdfaecc096ff3.tar.xz qemu-5666dd19dd95d966be00d0c3e7efdfaecc096ff3.zip | |
qapi: dealloc visitor, fix premature free and iteration logic
Currently we do 3 things wrong:
1) The list iterator, in practice, is used in a manner where the pointer
we pass in is the same as the pointer we assign the output to from
visit_next_list(). This causes an infinite loop where we keep freeing
the same structures.
2) We attempt to free list->value rather than list. visit_type_<type>
handles this. We should only be concerned with the containing list.
3) We free prematurely: iterator function will continue accessing values
we've already freed.
This patch should fix all of these issues. QmpOutputVisitor also suffers
from 1).
Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Diffstat (limited to 'qapi/qmp-output-visitor.h')
0 files changed, 0 insertions, 0 deletions