diff options
| author | Peter Maydell | 2017-07-14 13:12:25 +0200 |
|---|---|---|
| committer | Samuel Thibault | 2017-07-15 14:28:25 +0200 |
| commit | 75cb298d905030fca897ea1d80e409c7f7e3e5ea (patch) | |
| tree | 225d193e413a20f4f5aaaedbbdd203942f6d8c26 /slirp/sbuf.c | |
| parent | slirp: Handle error returns from slirp_send() in sosendoob() (diff) | |
| download | qemu-75cb298d905030fca897ea1d80e409c7f7e3e5ea.tar.gz qemu-75cb298d905030fca897ea1d80e409c7f7e3e5ea.tar.xz qemu-75cb298d905030fca897ea1d80e409c7f7e3e5ea.zip | |
slirp: Handle error returns from sosendoob()
sosendoob() can return a failure code, but all its callers ignore it.
This is OK in sbappend(), as the comment there states -- we will try
again later in sowrite(). Add a (void) cast to tell Coverity so.
In sowrite() we do need to check the return value -- we should handle
a write failure in sosendoob() the same way we handle a write failure
for the normal data.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Diffstat (limited to 'slirp/sbuf.c')
| -rw-r--r-- | slirp/sbuf.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/slirp/sbuf.c b/slirp/sbuf.c index 10119d3ad5..912f235f65 100644 --- a/slirp/sbuf.c +++ b/slirp/sbuf.c @@ -91,7 +91,7 @@ sbappend(struct socket *so, struct mbuf *m) if (so->so_urgc) { sbappendsb(&so->so_rcv, m); m_free(m); - sosendoob(so); + (void)sosendoob(so); return; } |