diff options
| author | Peter Maydell | 2018-11-06 16:13:22 +0100 |
|---|---|---|
| committer | Samuel Thibault | 2018-11-10 15:07:53 +0100 |
| commit | 4ded9bb54ceefeb68e766fe9aafc10de934c4501 (patch) | |
| tree | 1dfac08e3ce18c48ea46626f3383f9212d9de0d7 /slirp/socket.c | |
| parent | slirp: Use g_new() to allocate sockets in socreate() (diff) | |
| download | qemu-4ded9bb54ceefeb68e766fe9aafc10de934c4501.tar.gz qemu-4ded9bb54ceefeb68e766fe9aafc10de934c4501.tar.xz qemu-4ded9bb54ceefeb68e766fe9aafc10de934c4501.zip | |
slirp: Remove code that handles socreate() failure
Now that socreate() can never fail, we can remove the code
that was trying to handle that situation.
In particular this removes code in tcp_connect() that
provoked Coverity to complain (CID 1005724): in
closesocket(accept(inso->s, (struct sockaddr *)&addr, &addrlen));
if the accept() call fails then we pass closesocket() -1
instead of a valid file descriptor.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Diffstat (limited to 'slirp/socket.c')
| -rw-r--r-- | slirp/socket.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/slirp/socket.c b/slirp/socket.c index 35a9a14565..c01d8696af 100644 --- a/slirp/socket.c +++ b/slirp/socket.c @@ -713,9 +713,6 @@ tcp_listen(Slirp *slirp, uint32_t haddr, u_int hport, uint32_t laddr, DEBUG_ARG("flags = %x", flags); so = socreate(slirp); - if (!so) { - return NULL; - } /* Don't tcp_attach... we don't need so_snd nor so_rcv */ if ((so->so_tcpcb = tcp_newtcpcb(so)) == NULL) { |