diff options
| author | Stefan Hajnoczi | 2016-06-02 02:40:31 +0200 |
|---|---|---|
| committer | Stefan Hajnoczi | 2016-06-07 15:40:51 +0200 |
| commit | 8860eabdee32f78d9a34273a340b8f74476bc9a0 (patch) | |
| tree | a16f9e8cd15be4e1f337c7bcbcfd874db06f1e8e /util | |
| parent | block: Drop bdrv_ioctl_bh_cb (diff) | |
| download | qemu-8860eabdee32f78d9a34273a340b8f74476bc9a0.tar.gz qemu-8860eabdee32f78d9a34273a340b8f74476bc9a0.tar.xz qemu-8860eabdee32f78d9a34273a340b8f74476bc9a0.zip | |
throttle: refuse iops-size without iops-total/read/write
In a similar vein to commit ee2bdc33c913b7d765baa5aa338c29fb30a05c9a
("throttle: refuse bps_max/iops_max without bps/iops") it is likely that
the user made a configuration error if iops-size has been set but no
iops limit has been set.
Print an error message so the user can check their throttling
configuration. They should either remove iops-size if they don't want
any throttling or specify one of iops-total, iops-read, or iops-write.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Message-id: 1464828031-25601-1-git-send-email-stefanha@redhat.com
Diffstat (limited to 'util')
| -rw-r--r-- | util/throttle.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/util/throttle.c b/util/throttle.c index 71246b2343..654f95caf2 100644 --- a/util/throttle.c +++ b/util/throttle.c @@ -315,6 +315,14 @@ bool throttle_is_valid(ThrottleConfig *cfg, Error **errp) return false; } + if (cfg->op_size && + !cfg->buckets[THROTTLE_OPS_TOTAL].avg && + !cfg->buckets[THROTTLE_OPS_READ].avg && + !cfg->buckets[THROTTLE_OPS_WRITE].avg) { + error_setg(errp, "iops size requires an iops value to be set"); + return false; + } + for (i = 0; i < BUCKETS_COUNT; i++) { if (cfg->buckets[i].avg < 0 || cfg->buckets[i].max < 0 || |