From 25349e8250e67e7d126fbf0ad213811b62e7e529 Mon Sep 17 00:00:00 2001 From: Klaus Birkelund Jensen Date: Sat, 18 May 2019 09:39:05 +0200 Subject: nvme: fix copy direction in DMA reads going to CMB `nvme_dma_read_prp` erronously used `qemu_iovec_*to*_buf` instead of `qemu_iovec_*from*_buf` when the request involved the controller memory buffer. Signed-off-by: Klaus Birkelund Jensen Reviewed-by: Kenneth Heitke Signed-off-by: Kevin Wolf --- hw/block/nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'hw/block/nvme.c') diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 7caf92532a..63a5b58849 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -238,7 +238,7 @@ static uint16_t nvme_dma_read_prp(NvmeCtrl *n, uint8_t *ptr, uint32_t len, } qemu_sglist_destroy(&qsg); } else { - if (unlikely(qemu_iovec_to_buf(&iov, 0, ptr, len) != len)) { + if (unlikely(qemu_iovec_from_buf(&iov, 0, ptr, len) != len)) { trace_nvme_err_invalid_dma(); status = NVME_INVALID_FIELD | NVME_DNR; } -- cgit v1.2.3-55-g7522