From 64552b6be4758d3a774f7787b294543ccebd5358 Mon Sep 17 00:00:00 2001 From: Markus Armbruster Date: Mon, 12 Aug 2019 07:23:42 +0200 Subject: Include hw/irq.h a lot less In my "build everything" tree, changing hw/irq.h triggers a recompile of some 5400 out of 6600 objects (not counting tests and objects that don't depend on qemu/osdep.h). hw/hw.h supposedly includes it for convenience. Several other headers include it just to get qemu_irq and.or qemu_irq_handler. Move the qemu_irq and qemu_irq_handler typedefs from hw/irq.h to qemu/typedefs.h, and then include hw/irq.h only where it's still needed. Touching it now recompiles only some 500 objects. Signed-off-by: Markus Armbruster Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id: <20190812052359.30071-13-armbru@redhat.com> --- hw/core/or-irq.c | 1 + hw/core/qdev.c | 1 + hw/core/split-irq.c | 1 + 3 files changed, 3 insertions(+) (limited to 'hw/core') diff --git a/hw/core/or-irq.c b/hw/core/or-irq.c index 123a8c644a..6ed34d9238 100644 --- a/hw/core/or-irq.c +++ b/hw/core/or-irq.c @@ -23,6 +23,7 @@ */ #include "qemu/osdep.h" +#include "hw/irq.h" #include "hw/or-irq.h" #include "qemu/module.h" diff --git a/hw/core/qdev.c b/hw/core/qdev.c index 94ebc0a4a1..5c4b67a408 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -35,6 +35,7 @@ #include "qemu/error-report.h" #include "qemu/option.h" #include "hw/hotplug.h" +#include "hw/irq.h" #include "hw/boards.h" #include "hw/sysbus.h" diff --git a/hw/core/split-irq.c b/hw/core/split-irq.c index c606f4a802..6808e812b5 100644 --- a/hw/core/split-irq.c +++ b/hw/core/split-irq.c @@ -25,6 +25,7 @@ #include "qemu/osdep.h" #include "hw/core/split-irq.h" +#include "hw/irq.h" #include "qapi/error.h" #include "qemu/module.h" -- cgit v1.2.3-55-g7522