From d5938f29fea29581725426f203a74da746ca03e7 Mon Sep 17 00:00:00 2001 From: Markus Armbruster Date: Mon, 12 Aug 2019 07:23:56 +0200 Subject: Clean up inclusion of sysemu/sysemu.h In my "build everything" tree, changing sysemu/sysemu.h triggers a recompile of some 5400 out of 6600 objects (not counting tests and objects that don't depend on qemu/osdep.h). Almost a third of its inclusions are actually superfluous. Delete them. Downgrade two more to qapi/qapi-types-run-state.h, and move one from char/serial.h to char/serial.c. hw/semihosting/config.c, monitor/monitor.c, qdev-monitor.c, and stubs/semihost.c define variables declared in sysemu/sysemu.h without including it. The compiler is cool with that, but include it anyway. This doesn't reduce actual use much, as it's still included into widely included headers. The next commit will tackle that. Signed-off-by: Markus Armbruster Reviewed-by: Alistair Francis Message-Id: <20190812052359.30071-27-armbru@redhat.com> Reviewed-by: Alex Bennée --- hw/misc/armsse-cpuid.c | 1 - hw/misc/armsse-mhu.c | 1 - hw/misc/imx6_src.c | 1 - hw/misc/imx7_gpr.c | 1 - hw/misc/iotkit-sysinfo.c | 1 - hw/misc/mips_cmgcr.c | 1 - hw/misc/mos6522.c | 1 - hw/misc/sga.c | 1 - hw/misc/zynq-xadc.c | 1 - 9 files changed, 9 deletions(-) (limited to 'hw/misc') diff --git a/hw/misc/armsse-cpuid.c b/hw/misc/armsse-cpuid.c index 5f225096f6..8ab15fea81 100644 --- a/hw/misc/armsse-cpuid.c +++ b/hw/misc/armsse-cpuid.c @@ -23,7 +23,6 @@ #include "qemu/module.h" #include "trace.h" #include "qapi/error.h" -#include "sysemu/sysemu.h" #include "hw/sysbus.h" #include "hw/registerfields.h" #include "hw/misc/armsse-cpuid.h" diff --git a/hw/misc/armsse-mhu.c b/hw/misc/armsse-mhu.c index 34b6205f11..a45d97fada 100644 --- a/hw/misc/armsse-mhu.c +++ b/hw/misc/armsse-mhu.c @@ -20,7 +20,6 @@ #include "qemu/module.h" #include "trace.h" #include "qapi/error.h" -#include "sysemu/sysemu.h" #include "hw/sysbus.h" #include "migration/vmstate.h" #include "hw/registerfields.h" diff --git a/hw/misc/imx6_src.c b/hw/misc/imx6_src.c index b9d86fe530..8ab18967b5 100644 --- a/hw/misc/imx6_src.c +++ b/hw/misc/imx6_src.c @@ -11,7 +11,6 @@ #include "qemu/osdep.h" #include "hw/misc/imx6_src.h" #include "migration/vmstate.h" -#include "sysemu/sysemu.h" #include "qemu/bitops.h" #include "qemu/log.h" #include "qemu/main-loop.h" diff --git a/hw/misc/imx7_gpr.c b/hw/misc/imx7_gpr.c index 09d57d4710..b03341a2eb 100644 --- a/hw/misc/imx7_gpr.c +++ b/hw/misc/imx7_gpr.c @@ -16,7 +16,6 @@ #include "hw/misc/imx7_gpr.h" #include "qemu/log.h" #include "qemu/module.h" -#include "sysemu/sysemu.h" #include "trace.h" diff --git a/hw/misc/iotkit-sysinfo.c b/hw/misc/iotkit-sysinfo.c index 0106fa48d3..783e613959 100644 --- a/hw/misc/iotkit-sysinfo.c +++ b/hw/misc/iotkit-sysinfo.c @@ -22,7 +22,6 @@ #include "qemu/module.h" #include "trace.h" #include "qapi/error.h" -#include "sysemu/sysemu.h" #include "hw/sysbus.h" #include "hw/registerfields.h" #include "hw/misc/iotkit-sysinfo.h" diff --git a/hw/misc/mips_cmgcr.c b/hw/misc/mips_cmgcr.c index 0feab092f1..8176d91c0c 100644 --- a/hw/misc/mips_cmgcr.c +++ b/hw/misc/mips_cmgcr.c @@ -14,7 +14,6 @@ #include "qemu/module.h" #include "hw/sysbus.h" #include "migration/vmstate.h" -#include "sysemu/sysemu.h" #include "hw/misc/mips_cmgcr.h" #include "hw/misc/mips_cpc.h" #include "hw/qdev-properties.h" diff --git a/hw/misc/mos6522.c b/hw/misc/mos6522.c index 4d99350e22..57f13db266 100644 --- a/hw/misc/mos6522.c +++ b/hw/misc/mos6522.c @@ -31,7 +31,6 @@ #include "hw/qdev-properties.h" #include "migration/vmstate.h" #include "qemu/timer.h" -#include "sysemu/sysemu.h" #include "qemu/cutils.h" #include "qemu/log.h" #include "qemu/module.h" diff --git a/hw/misc/sga.c b/hw/misc/sga.c index da04924f5f..6866bf72cb 100644 --- a/hw/misc/sga.c +++ b/hw/misc/sga.c @@ -29,7 +29,6 @@ #include "hw/isa/isa.h" #include "hw/loader.h" #include "qemu/module.h" -#include "sysemu/sysemu.h" #define SGABIOS_FILENAME "sgabios.bin" diff --git a/hw/misc/zynq-xadc.c b/hw/misc/zynq-xadc.c index 7745df4c85..7b1972ce06 100644 --- a/hw/misc/zynq-xadc.c +++ b/hw/misc/zynq-xadc.c @@ -18,7 +18,6 @@ #include "hw/misc/zynq-xadc.h" #include "migration/vmstate.h" #include "qemu/timer.h" -#include "sysemu/sysemu.h" #include "qemu/log.h" #include "qemu/module.h" -- cgit v1.2.3-55-g7522