From b000dfbd42e8aac9af66ae0ed787ef1021bea29f Mon Sep 17 00:00:00 2001 From: Peter Maydell Date: Mon, 25 Mar 2013 13:40:44 +0000 Subject: hw/qdev-properties.c: Improve diagnostic for setting property after realize Now we have error_setg() we can improve the error message emitted if you attempt to set a property of a device after the device is realized (the previous message was "permission denied" which was not very informative). Signed-off-by: Peter Maydell Message-id: 1364218844-7509-1-git-send-email-peter.maydell@linaro.org Signed-off-by: Anthony Liguori --- hw/qdev-properties-system.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'hw/qdev-properties-system.c') diff --git a/hw/qdev-properties-system.c b/hw/qdev-properties-system.c index 87951444a1..28813d3978 100644 --- a/hw/qdev-properties-system.c +++ b/hw/qdev-properties-system.c @@ -43,7 +43,7 @@ static void set_pointer(Object *obj, Visitor *v, Property *prop, int ret; if (dev->realized) { - error_set(errp, QERR_PERMISSION_DENIED); + qdev_prop_set_after_realize(dev, name, errp); return; } @@ -287,7 +287,7 @@ static void set_vlan(Object *obj, Visitor *v, void *opaque, NetClientState *hubport; if (dev->realized) { - error_set(errp, QERR_PERMISSION_DENIED); + qdev_prop_set_after_realize(dev, name, errp); return; } -- cgit v1.2.3-55-g7522