From 5c17ca2505197c56d0097c66a4e5bda4d6f32fb6 Mon Sep 17 00:00:00 2001 From: Markus Armbruster Date: Wed, 7 Oct 2009 01:16:01 +0200 Subject: Clean up test for qdev_init() failure Some callers test for != 0, some for < 0. Normalize to < 0. Patchworks-ID: 35171 Signed-off-by: Markus Armbruster Signed-off-by: Anthony Liguori --- hw/serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'hw/serial.c') diff --git a/hw/serial.c b/hw/serial.c index e044923101..eb14f11ba1 100644 --- a/hw/serial.c +++ b/hw/serial.c @@ -759,7 +759,7 @@ SerialState *serial_isa_init(int index, CharDriverState *chr) qdev_prop_set_uint32(&dev->qdev, "iobase", isa_serial_io[index]); qdev_prop_set_uint32(&dev->qdev, "irq", isa_serial_irq[index]); qdev_prop_set_chr(&dev->qdev, "chardev", chr); - if (qdev_init(&dev->qdev) != 0) + if (qdev_init(&dev->qdev) < 0) return NULL; return &DO_UPCAST(ISASerialState, dev, dev)->state; } -- cgit v1.2.3-55-g7522