From 98f28ad7a7d26e5e77c5cb37b262d76d6ccd963d Mon Sep 17 00:00:00 2001 From: Markus Armbruster Date: Tue, 6 Jul 2010 14:37:44 +0200 Subject: ide scsi virtio-blk: Reject empty drives unless media is removable Disks without media make no sense. For SCSI, a Linux guest kernel complains during boot. I didn't try other combinations. scsi-generic doesn't need the additional check, because it already requires bdrv_is_sg(), which fails without media. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- hw/virtio-blk.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'hw/virtio-blk.c') diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index 99e9dd294b..f50069d20b 100644 --- a/hw/virtio-blk.c +++ b/hw/virtio-blk.c @@ -495,6 +495,10 @@ VirtIODevice *virtio_blk_init(DeviceState *dev, BlockConf *conf) error_report("virtio-blk-pci: drive property not set"); return NULL; } + if (!bdrv_is_inserted(conf->bs)) { + error_report("Device needs media, but drive is empty"); + return NULL; + } s = (VirtIOBlock *)virtio_common_init("virtio-blk", VIRTIO_ID_BLOCK, sizeof(struct virtio_blk_config), -- cgit v1.2.3-55-g7522