From 24f3902b088cd4f2dbebfd90527b5d81d6a050e9 Mon Sep 17 00:00:00 2001 From: Greg Kurz Date: Wed, 4 May 2016 21:44:19 +0200 Subject: savevm: fail if migration blockers are present QEMU has currently two ways to prevent migration to occur: - migration blocker when it depends on runtime state - VMStateDescription.unmigratable when migration is not supported at all This patch gathers all the logic into a single function to be called from both the savevm and the migrate paths. This fixes a bug with 9p, at least, where savevm would succeed and the following would happen in the guest after loadvm: $ ls /host ls: cannot access /host: Protocol error With this patch: (qemu) savevm foo Migration is disabled when VirtFS export path '/' is mounted in the guest using mount_tag 'host' Signed-off-by: Greg Kurz Reviewed-by: Paolo Bonzini Message-Id: <146239057139.11271.9011797645454781543.stgit@bahia.huguette.org> [Update subject according to Paolo's suggestion - Amit] Signed-off-by: Amit Shah --- include/migration/migration.h | 1 + 1 file changed, 1 insertion(+) (limited to 'include') diff --git a/include/migration/migration.h b/include/migration/migration.h index ac2c12c2a5..9e36a97fc5 100644 --- a/include/migration/migration.h +++ b/include/migration/migration.h @@ -210,6 +210,7 @@ int migrate_fd_close(MigrationState *s); void add_migration_state_change_notifier(Notifier *notify); void remove_migration_state_change_notifier(Notifier *notify); MigrationState *migrate_init(const MigrationParams *params); +bool migration_is_blocked(Error **errp); bool migration_in_setup(MigrationState *); bool migration_has_finished(MigrationState *); bool migration_has_failed(MigrationState *); -- cgit v1.2.3-55-g7522