From ec5b6c9c5de985769a3d816b85cfe707a2decb93 Mon Sep 17 00:00:00 2001 From: Marc-André Lureau Date: Thu, 6 Oct 2022 15:36:56 +0400 Subject: io/command: implement support for win32 The initial implementation was changing the pipe state created by GLib to PIPE_NOWAIT, but it turns out it doesn't work (read/write returns an error). Since reading may return less than the requested amount, it seems to be non-blocking already. However, the IO operation may block until the FD is ready, I can't find good sources of information, to be safe we can just poll for readiness before. Alternatively, we could setup the FDs ourself, and use UNIX sockets on Windows, which can be used in blocking/non-blocking mode. I haven't tried it, as I am not sure it is necessary. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Message-Id: <20221006113657.2656108-6-marcandre.lureau@redhat.com> --- include/io/channel-command.h | 3 +++ 1 file changed, 3 insertions(+) (limited to 'include') diff --git a/include/io/channel-command.h b/include/io/channel-command.h index 8dc58273c0..98934e6d9e 100644 --- a/include/io/channel-command.h +++ b/include/io/channel-command.h @@ -42,6 +42,9 @@ struct QIOChannelCommand { int writefd; int readfd; GPid pid; +#ifdef WIN32 + bool blocking; +#endif }; -- cgit v1.2.3-55-g7522