From 626ff6515d41854dc8a880849ae2744c20a70ba7 Mon Sep 17 00:00:00 2001 From: Daniel P. BerrangĂ© Date: Thu, 15 Apr 2021 14:33:51 +0100 Subject: migration: add trace point when vm_stop_force_state fails This is a critical failure scenario for migration that is hard to diagnose from existing probes. Most likely it is caused by an error from bdrv_flush(), but we're not logging the errno anywhere, hence this new probe. Reviewed-by: Connor Kuehl Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. BerrangĂ© --- migration/migration.c | 1 + 1 file changed, 1 insertion(+) (limited to 'migration/migration.c') diff --git a/migration/migration.c b/migration/migration.c index 4828997f63..4228635d18 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -3115,6 +3115,7 @@ static void migration_completion(MigrationState *s) if (!ret) { bool inactivate = !migrate_colo_enabled(); ret = vm_stop_force_state(RUN_STATE_FINISH_MIGRATE); + trace_migration_completion_vm_stop(ret); if (ret >= 0) { ret = migration_maybe_pause(s, ¤t_active_state, MIGRATION_STATUS_DEVICE); -- cgit v1.2.3-55-g7522