From db725815985654007ade0fd53590d613fd657208 Mon Sep 17 00:00:00 2001 From: Markus Armbruster Date: Mon, 12 Aug 2019 07:23:50 +0200 Subject: Include qemu/main-loop.h less In my "build everything" tree, changing qemu/main-loop.h triggers a recompile of some 5600 out of 6600 objects (not counting tests and objects that don't depend on qemu/osdep.h). It includes block/aio.h, which in turn includes qemu/event_notifier.h, qemu/notify.h, qemu/processor.h, qemu/qsp.h, qemu/queue.h, qemu/thread-posix.h, qemu/thread.h, qemu/timer.h, and a few more. Include qemu/main-loop.h only where it's needed. Touching it now recompiles only some 1700 objects. For block/aio.h and qemu/event_notifier.h, these numbers drop from 5600 to 2800. For the others, they shrink only slightly. Signed-off-by: Markus Armbruster Message-Id: <20190812052359.30071-21-armbru@redhat.com> Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- migration/block.c | 1 + migration/colo.c | 1 + migration/migration.c | 1 + migration/savevm.c | 1 + 4 files changed, 4 insertions(+) (limited to 'migration') diff --git a/migration/block.c b/migration/block.c index 91f98ef44a..e81fd7e14f 100644 --- a/migration/block.c +++ b/migration/block.c @@ -16,6 +16,7 @@ #include "qemu/osdep.h" #include "qapi/error.h" #include "qemu/error-report.h" +#include "qemu/main-loop.h" #include "qemu/cutils.h" #include "qemu/queue.h" #include "block.h" diff --git a/migration/colo.c b/migration/colo.c index 0b5b620391..0602e6bbe4 100644 --- a/migration/colo.c +++ b/migration/colo.c @@ -23,6 +23,7 @@ #include "io/channel-buffer.h" #include "trace.h" #include "qemu/error-report.h" +#include "qemu/main-loop.h" #include "qemu/rcu.h" #include "migration/failover.h" #ifdef CONFIG_REPLICATION diff --git a/migration/migration.c b/migration/migration.c index 8a607fe1e2..85e5d22e32 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -16,6 +16,7 @@ #include "qemu/osdep.h" #include "qemu/cutils.h" #include "qemu/error-report.h" +#include "qemu/main-loop.h" #include "migration/blocker.h" #include "exec.h" #include "fd.h" diff --git a/migration/savevm.c b/migration/savevm.c index 89e8f4c180..b8f734537a 100644 --- a/migration/savevm.c +++ b/migration/savevm.c @@ -51,6 +51,7 @@ #include "exec/target_page.h" #include "trace.h" #include "qemu/iov.h" +#include "qemu/main-loop.h" #include "block/snapshot.h" #include "qemu/cutils.h" #include "io/channel-buffer.h" -- cgit v1.2.3-55-g7522