From 42eab8dbec2f3fd4a14bd63ab01aa155ce5724a3 Mon Sep 17 00:00:00 2001 From: Marc-André Lureau Date: Thu, 5 Jul 2018 18:42:01 +0200 Subject: monitor: fix double-free of request error qmp_error_response() will free the given error. Fix double-free in later qmp_request_free(). Signed-off-by: Marc-André Lureau Message-Id: <20180705164201.9853-1-marcandre.lureau@redhat.com> Reviewed-by: Markus Armbruster Fixes: 1cc37471525d03f963bc71d724f0dc9eab888fc1 Signed-off-by: Markus Armbruster --- monitor.c | 1 + 1 file changed, 1 insertion(+) (limited to 'monitor.c') diff --git a/monitor.c b/monitor.c index 3c9c97b73f..7af1f18d13 100644 --- a/monitor.c +++ b/monitor.c @@ -4186,6 +4186,7 @@ static void monitor_qmp_bh_dispatcher(void *data) } else { assert(req_obj->err); rsp = qmp_error_response(req_obj->err); + req_obj->err = NULL; monitor_qmp_respond(req_obj->mon, rsp, NULL); qobject_unref(rsp); } -- cgit v1.2.3-55-g7522