From 6287d827d494b5850049584c3f7fb1a589dbb1de Mon Sep 17 00:00:00 2001 From: Daniel P. Berrange Date: Fri, 11 Sep 2015 13:33:56 +0100 Subject: monitor: allow device_del to accept QOM paths Currently device_del requires that the client provide the device short ID. device_add allows devices to be created without giving an ID, at which point there is no way to delete them with device_del. The QOM object path, however, provides an alternative way to identify the devices. Allowing device_del to accept an object path ensures all devices are deletable regardless of whether they have an ID. (qemu) device_add usb-mouse (qemu) qom-list /machine/peripheral-anon device[0] (child) type (string) (qemu) device_del /machine/peripheral-anon/device[0] Devices are required to be marked as hotpluggable otherwise an error is raised (qemu) device_del /machine/unattached/device[4] Device 'PIIX3' does not support hotplugging Signed-off-by: Daniel P. Berrange Message-Id: <1441974836-17476-1-git-send-email-berrange@redhat.com> Reviewed-by: Eric Blake [Commit message touched up, accidental white-space change dropped] Signed-off-by: Markus Armbruster --- qapi-schema.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'qapi-schema.json') diff --git a/qapi-schema.json b/qapi-schema.json index 821362d637..527690dfe0 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -1951,7 +1951,7 @@ # # Remove a device from a guest # -# @id: the name of the device +# @id: the name or QOM path of the device # # Returns: Nothing on success # If @id is not a valid device, DeviceNotFound -- cgit v1.2.3-55-g7522