From 0153d2f50bc2ad3f41810d838fcf66acbf10f07a Mon Sep 17 00:00:00 2001 From: Kevin Wolf Date: Fri, 7 Oct 2016 17:05:04 +0200 Subject: block: Remove "options" indirection from blockdev-add Now that QAPI supports boxed types, we can have unions at the top level of a command, so let's put our real options directly there for blockdev-add instead of having a single "options" dict that contains the real arguments. blockdev-add is still experimental and we already made substantial changes to the API recently, so we're free to make changes like this one, too. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Reviewed-by: Max Reitz --- qapi/block-core.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'qapi') diff --git a/qapi/block-core.json b/qapi/block-core.json index 1b7aa1befd..c59047bc94 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -2312,11 +2312,11 @@ # block drivers among other things. Stay away from it unless you want # to help with its development. # -# @options: block device options for the new device +# For the arguments, see the documentation of BlockdevOptions. # # Since: 1.7 ## -{ 'command': 'blockdev-add', 'data': { 'options': 'BlockdevOptions' } } +{ 'command': 'blockdev-add', 'data': 'BlockdevOptions', 'boxed': true } ## # @x-blockdev-del: -- cgit v1.2.3-55-g7522