From 7ea14df230b98ffb33342f40cfffbdbb8ddd2b06 Mon Sep 17 00:00:00 2001 From: Philippe Mathieu-Daudé Date: Thu, 4 Feb 2021 12:48:24 +0000 Subject: migration: Make save_snapshot() return bool, not 0/-1 Just for consistency, following the example documented since commit e3fe3988d7 ("error: Document Error API usage rules"), return a boolean value indicating an error is set or not. Reviewed-by: Dr. David Alan Gilbert Acked-by: Pavel Dovgalyuk Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210204124834.774401-3-berrange@redhat.com> Signed-off-by: Dr. David Alan Gilbert --- replay/replay-debugging.c | 2 +- replay/replay-snapshot.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'replay') diff --git a/replay/replay-debugging.c b/replay/replay-debugging.c index 3a9b609e62..8e0050915d 100644 --- a/replay/replay-debugging.c +++ b/replay/replay-debugging.c @@ -323,7 +323,7 @@ void replay_gdb_attached(void) */ if (replay_mode == REPLAY_MODE_PLAY && !replay_snapshot) { - if (save_snapshot("start_debugging", NULL) != 0) { + if (!save_snapshot("start_debugging", NULL)) { /* Can't create the snapshot. Continue conventional debugging. */ } } diff --git a/replay/replay-snapshot.c b/replay/replay-snapshot.c index e26fa4c892..4f2560d156 100644 --- a/replay/replay-snapshot.c +++ b/replay/replay-snapshot.c @@ -77,7 +77,7 @@ void replay_vmstate_init(void) if (replay_snapshot) { if (replay_mode == REPLAY_MODE_RECORD) { - if (save_snapshot(replay_snapshot, &err) != 0) { + if (!save_snapshot(replay_snapshot, &err)) { error_report_err(err); error_report("Could not create snapshot for icount record"); exit(1); -- cgit v1.2.3-55-g7522