From 9be385980d37e8f4fd33f605f5fb1c3d144170a8 Mon Sep 17 00:00:00 2001 From: Eduardo Habkost Date: Mon, 13 Jun 2016 18:57:58 -0300 Subject: coccinelle: Remove unnecessary variables for function return value Use Coccinelle script to replace 'ret = E; return ret' with 'return E'. The script will do the substitution only when the function return type and variable type are the same. Manual fixups: * audio/audio.c: coding style of "read (...)" and "write (...)" * block/qcow2-cluster.c: wrap line to make it shorter * block/qcow2-refcount.c: change indentation of wrapped line * target-tricore/op_helper.c: fix coding style of "remainder|quotient" * target-mips/dsp_helper.c: reverted changes because I don't want to argue about checkpatch.pl * ui/qemu-pixman.c: fix line indentation * block/rbd.c: restore blank line between declarations and statements Reviewed-by: Eric Blake Signed-off-by: Eduardo Habkost Message-Id: <1465855078-19435-4-git-send-email-ehabkost@redhat.com> Reviewed-by: Markus Armbruster [Unused Coccinelle rule name dropped along with a redundant comment; whitespace touched up in block/qcow2-cluster.c; stale commit message paragraph deleted] Signed-off-by: Markus Armbruster --- util/module.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'util/module.c') diff --git a/util/module.c b/util/module.c index ce058aef6f..86e3f7aba0 100644 --- a/util/module.c +++ b/util/module.c @@ -55,13 +55,9 @@ static void init_lists(void) static ModuleTypeList *find_type(module_init_type type) { - ModuleTypeList *l; - init_lists(); - l = &init_type_list[type]; - - return l; + return &init_type_list[type]; } void register_module_init(void (*fn)(void), module_init_type type) -- cgit v1.2.3-55-g7522