From d10e05f15d5c3dd5e5cc59c5dfff460d89d48580 Mon Sep 17 00:00:00 2001 From: Markus Armbruster Date: Wed, 17 Oct 2018 10:26:53 +0200 Subject: tpm: Clean up error reporting in tpm_init_tpmdev() Calling error_report() in a function that takes an Error ** argument is suspicious. tpm_init_tpmdev() does that, and then fails without setting an error. Its caller main(), via tpm_init() and qemu_opts_foreach(), is fine with it, but clean it up anyway. Cc: Stefan Berger Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Marc-André Lureau Reviewed-by: Stefan Berger Message-Id: <20181017082702.5581-30-armbru@redhat.com> --- vl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'vl.c') diff --git a/vl.c b/vl.c index 2ff0c5f32d..2f265b9c74 100644 --- a/vl.c +++ b/vl.c @@ -4360,9 +4360,7 @@ int main(int argc, char **argv, char **envp) user_creatable_add_opts_foreach, object_create_delayed, &error_fatal); - if (tpm_init() < 0) { - exit(1); - } + tpm_init(); /* init the bluetooth world */ if (foreach_device_config(DEV_BT, bt_parse)) -- cgit v1.2.3-55-g7522