openslx-ng/ipxe.git/src/arch/x86/prefix, branch master

[pci] Correct invalid base-class/sub-class/prog-if order in PCIR

2019-01-15T13:08:44+00:00

PCI Configuration Space contains fields prog-if at the offset 0x09, sub-class at the offset 0x0a and base-class at the offset 0x0b (it respects little endian). PCIR structure uses these fields in the same order. Signed-off-by: Michael Brown

[build] Avoid use of "ld --oformat binary"

2018-01-02T20:26:40+00:00

Using "ld --oformat binary" for mbr.bin and usbdisk.bin seems to cause segmentation faults on some versions of binutils (observed on Fedora 27). Work around this problem by using ld to create an intermediate ELF object, followed by objcopy (via the existing %.tmp -> %.bin rule) to create the final binary. Note that we cannot simply use a single-stage "objcopy -O binary" since this will not process the relocation records for x86_64: see commit 1afcccd ("[build] Do not use "objcopy -O binary" for objects with relocation records"). Reported-by: Brent S Signed-off-by: Michael Brown

[romprefix] Avoid unaligned accesses within ROM headers

2017-08-30T09:15:25+00:00

Ensure that all headers (PCI, UNDI, PnP, iPXE) are aligned to at least four bytes, so that all accesses to header fields will be correctly aligned even when reading directly from the expansion ROM BAR. Reported-by: Peter von Konigsmark Signed-off-by: Michael Brown

[hdprefix] Avoid attempts to read beyond the end of the disk

2017-06-14T11:14:54+00:00

When booting from a hard disk image (e.g. bin/ipxe.usb) within an emulator such as QEMU, the disk may not exist beyond the end of the image. Limit all reads to the length of the image to avoid spurious errors when loading the iPXE image. Signed-off-by: Michael Brown

[prefix] Include diagnostic information within progress messages

2016-12-06T09:38:33+00:00

Include some relevant diagnostic infomation within the progress messages generated via DEBUG=libprefix. Signed-off-by: Michael Brown

[prefix] Remove impossible progress message

2016-12-06T07:44:10+00:00

The "progress" macro can be used only from within the .prefix section. At the point of calling relocate(), we are running in .text16 and so the near call to print_message() will end up calling a random function somewhere in .text16. Interestingly, this problem has remained unnoticed for some time. It is rare to build with DEBUG=libprefix. In the few cases that it has been used during development, the randomly selected function in .text16 seems to have been a harmless no-op with no visible side-effects (beyond the unnoticed failure to print the "relocate" progress message). Fix by removing the futile attempt to print a progress message before calling relocate(). Reported-by: Raed Salem Signed-off-by: Michael Brown

[romprefix] Avoid using PMM-allocated memory in UNDI loader entry point

2016-12-05T15:21:45+00:00

The UNDI loader entry point is very likely to be called after POST, when there is a high chance that the PMM-allocated image source area and decompression area have been reused by something else. In particular, using an iPXE .iso to test a separate iPXE ROM's UNDI loader entry point in a qemu VM is likely to crash. SeaBIOS allocates PMM blocks from close to the top of memory and so these blocks have a high chance of colliding with the runtime addresses subsequently chosen by the non-ROM iPXE by scanning the INT 15,e820 memory map. The standard romprefix.S has no choice about relying on the PMM-allocated image source area, since it has no other way to retrieve its compressed payload. In mromprefix.S, the image source area functions only as an optional buffer used to avoid repeated reads from the (potentially slow) expansion ROM BAR by the decompression code. We can therefore always set %esi=0 when calling install_prealloc from the UNDI loader entry point, and simply fall back to reading directly from the expansion ROM BAR. We can always set %edi=0 when calling install_prealloc from the UNDI loader entry point. This will behave as though the decompression area PMM allocation failed, and will therefore use INT 15,88 to find a temporary decompression area somewhere close to 64MB. This is by no means guaranteed to be safe from collisions, but it's probably safer on balance than the PMM-allocated address. Signed-off-by: Michael Brown

[prefix] Use CRC32 to verify each block prior to decompression

2016-03-24T16:52:26+00:00

Signed-off-by: Michael Brown

[efi] Move architecture-independent EFI prefixes to interface/efi

2016-03-17T14:51:14+00:00

Signed-off-by: Michael Brown

[librm] Provide an abstraction wrapper for prot_call

2016-02-18T23:23:38+00:00

Signed-off-by: Michael Brown