openslx-ng/ipxe.git/src/drivers/net/efi, branch master

[efi] Provide Map_Mem() and associated UNDI callbacks

2018-03-20T11:31:45+00:00

Some drivers are known to call the optional Map_Mem() callback without first checking that the callback exists. Provide a usable basic implementation of Map_Mem() along with the other callbacks that become mandatory if Map_Mem() is provided. Note that in theory the PCI I/O protocol is allowed to require multiple calls to Map(), with each call handling only a subset of the overall mapped range. However, the reference implementation in EDK2 assumes that a single Map() will always suffice, so we can probably make the same simplifying assumption here. Tested with the Intel E3522X2.EFI driver (which, incidentally, fails to cleanly remove one of its mappings). Originally-implemented-by: Maor Dickman Signed-off-by: Michael Brown

[efi] Raise TPL when calling UNDI entry point

2017-09-05T09:48:41+00:00

The SnpDxe driver raises the task priority level to TPL_CALLBACK when calling the UNDI entry point. This does not appear to be a documented requirement, but we should probably match the behaviour of SnpDxe to minimise surprises to third party code. Signed-off-by: Michael Brown

[efi] Enumerate PCI BARs in same order as SnpDxe

2017-07-21T14:00:17+00:00

The UEFI specification has an implicit and demonstrably incorrect requirement (in the Mem_IO() calling convention) that any UNDI network device has at most one memory BAR and one I/O BAR. Some UEFI platforms have been observed to report the existence of non-existent additional I/O BARs, causing iPXE to select the wrong BAR. This problem does not affect the SnpDxe driver, since that driver will always choose the lowest numbered existent BAR of each type. Adjust iPXE's behaviour to match that of SnpDxe, i.e. to always select the lowest numbered BAR(s). Debugged-by: Andreas Hammarskjöld Debugged-by: Adklei Signed-off-by: Michael Brown

[efi] Skip cable detection at initialisation where possible

2017-03-19T13:30:27+00:00

We currently request cable detection in PXE_OPCODE_INITIALIZE to work around buggy Emulex drivers (see commit c0b61ba ("[efi] Work around bugs in Emulex NII driver")). This causes problems with some other NII drivers (e.g. Mellanox), which may time out if the underlying link is intrinsically slow to come up. Attempt to work around both problems simultaneously by requesting cable detection only if the underlying NII driver does not support link status reporting via PXE_OPCODE_GET_STATUS. (This is based on a potentially incorrect assumption that the buggy Emulex drivers do not claim to report link status via PXE_OPCODE_GET_STATUS.) Signed-off-by: Michael Brown

[efi] Guard against GetStatus() failing to return a NULL TX buffer

2016-05-11T22:02:10+00:00

The UEFI specification requires the EFI_SIMPLE_NETWORK_PROTOCOL GetStatus() method to set TxBuf to NULL if there are no transmit buffers to recycle. Some implementations (observed with Lan9118Dxe in EDK2) fill in TxBuf only when there is a transmit buffer to recycle, which leads to large numbers of "spurious TX completion" errors. Work around this problem by initialising TxBuf to NULL before calling the GetStatus() method. Signed-off-by: Michael Brown

[efi] Remove raw EFI_HANDLE values from debug messages

2015-08-27T14:40:44+00:00

The raw EFI_HANDLE value is almost never useful to know, and simply adds noise to the already verbose debug messages. Improve the legibility of debug messages by using only the name generated by efi_handle_name(). Signed-off-by: Michael Brown

[efi] Work around bugs in Emulex NII driver

2015-08-17T14:57:05+00:00

Modified-by: Michael Brown Signed-off-by: Michael Brown

[efi] Improve NII driver logging

2015-08-17T14:55:48+00:00

Modified-by: Michael Brown Signed-off-by: Michael Brown

[efi] Poll for TX completions only when there is an outstanding TX buffer

2015-04-14T16:02:00+00:00

At least one NII implementation (in a Microsoft Surface tablet) seems to fail to report the absence (sic) of TX completions properly. Work around this by checking for TX completions only when we expect to see one. Signed-off-by: Michael Brown

[efi] Poll media status only if advertised as supported

2015-04-14T15:44:37+00:00

Some NII implementations will fail the GET_STATUS operation if we request the media status. Fix by doing so only if GET_INIT_INFO reported that media status is supported. Signed-off-by: Michael Brown